From b05eb9d9e79121ffd1e697921f6112e306a294c3 Mon Sep 17 00:00:00 2001 From: SulfurNitride Date: Tue, 28 Apr 2026 22:26:30 -0500 Subject: clang-tidy: apply auto-fixes from safest checks across our authored code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ran sequentially (not parallel — concurrent fixes corrupt shared headers) on src/src/ + libs/skse_log_redirector/. The check set: - modernize-use-override - modernize-use-nullptr - modernize-use-default-member-init - readability-redundant-member-init - readability-container-contains - readability-container-size-empty Net effect: ~108 files updated, 425/426 lines changed (overrides added, NULL/0 -> nullptr, member-init lists pruned where the same value is already in the in-class default). Build verified after revert/re-apply. Also disable readability-redundant-access-specifiers in .clang-tidy: the check is confused by Qt's `private slots:` specifier and strips the `private:` that follows it, breaking MOC. Co-Authored-By: Claude Opus 4.7 (1M context) --- .clang-tidy | 3 +++ 1 file changed, 3 insertions(+) (limited to '.clang-tidy') diff --git a/.clang-tidy b/.clang-tidy index ce05d5f..050b3f1 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -22,6 +22,8 @@ # positives in plumbing code. # - misc-include-cleaner / -no-recursion / -non-private-member-variables- # in-classes: noisy and partly redundant with clangd. +# - readability-redundant-access-specifiers: confused by Qt's `private slots:` +# specifier — strips the `private:` that follows it, breaking MOC. Checks: > bugprone-*, performance-*, @@ -43,6 +45,7 @@ Checks: > -readability-uppercase-literal-suffix, -readability-braces-around-statements, -readability-else-after-return, + -readability-redundant-access-specifiers, -bugprone-easily-swappable-parameters, -bugprone-branch-clone, -bugprone-narrowing-conversions, -- cgit v1.3.1