From b36a4f0c564d777f82b24a36a265b37ffbeafd2d Mon Sep 17 00:00:00 2001
From: SulfurNitride <SulfurNitride@users.noreply.github.com>
Date: Thu, 23 Apr 2026 19:37:07 -0500
Subject: Fix Updates tab compile + CI failure propagation

- settingsdialogupdates.cpp missed an include of settings.h (it was only
  getting the forward-declared version from settingsdialog.h), which
  broke every settings().setX() call. Now included directly.
- UpdatesSettingsTab is not a QObject so it has no tr() member; add
  Q_DECLARE_TR_FUNCTIONS to get a static tr() via QCoreApplication.
- CI: the docker run chained commands with `;` so a ninja failure got
  masked by the trailing `ccache -s`. Capture the build-inner.sh exit
  status and `exit $status` at the end so real build failures fail the
  step instead of bleeding into the tar packaging step and producing a
  confusing "Cannot stat: No such file" error.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .github/workflows/ci.yml          | 2 +-
 src/src/settingsdialogupdates.cpp | 1 +
 src/src/settingsdialogupdates.h   | 3 +++
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 757909e..0525c28 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -71,7 +71,7 @@ jobs:
             -e FLUORINE_BUILD_COMMIT=${{ steps.channel.outputs.commit }} \
             -w /src \
             fluorine-builder:latest \
-            bash -c 'ccache -s; bash /src/docker/build-inner.sh; echo "=== ccache stats after build ==="; ccache -s'
+            bash -c 'ccache -s; bash /src/docker/build-inner.sh; status=$?; echo "=== ccache stats after build ==="; ccache -s; exit $status'
 
       - name: Package tarball
         run: |
diff --git a/src/src/settingsdialogupdates.cpp b/src/src/settingsdialogupdates.cpp
index b46ff1e..c5441d1 100644
--- a/src/src/settingsdialogupdates.cpp
+++ b/src/src/settingsdialogupdates.cpp
@@ -1,6 +1,7 @@
 #include "settingsdialogupdates.h"
 
 #include "fluorineupdater.h"
+#include "settings.h"
 #include "ui_settingsdialog.h"
 
 #include <fluorine_build_info.h>
diff --git a/src/src/settingsdialogupdates.h b/src/src/settingsdialogupdates.h
index 7a39311..9712beb 100644
--- a/src/src/settingsdialogupdates.h
+++ b/src/src/settingsdialogupdates.h
@@ -3,6 +3,8 @@
 
 #include "settingsdialog.h"
 
+#include <QCoreApplication>
+
 class QCheckBox;
 class QComboBox;
 class QLabel;
@@ -15,6 +17,7 @@ class FluorineUpdater;
 // "Check for updates now" button with live status feedback.
 class UpdatesSettingsTab : public SettingsTab
 {
+  Q_DECLARE_TR_FUNCTIONS(UpdatesSettingsTab)
 public:
   UpdatesSettingsTab(Settings& settings, SettingsDialog& dialog);
 
-- 
cgit v1.3.1