From c360dbf9c42f71e7931c56b7a396ba7f7e9982e6 Mon Sep 17 00:00:00 2001 From: SulfurNitride Date: Mon, 23 Feb 2026 17:44:12 -0600 Subject: Remove umu-run, keep game as child process for Steam tracking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove umu-run entirely (crashed due to pressure-vessel/FUSE incompatibility) — use raw `proton run` instead - Replace startDetached() with QProcess::start() so the game stays in Fluorine's process tree. This lets Steam track the game lifetime and makes the "close game" button work when Fluorine is added as a non-Steam game. - Add writeIniValueDirect/readIniValueDirect for safe Bethesda INI handling without QSettings corruption - Fix prefix_setup.rs to skip umu-run bootstrapping - Clean up settings UI, build scripts, and docs for umu-run removal Co-Authored-By: Claude Opus 4.6 --- .../src/gamebryo/gamebryolocalsavegames.cpp | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) (limited to 'libs/game_bethesda/src/gamebryo/gamebryolocalsavegames.cpp') diff --git a/libs/game_bethesda/src/gamebryo/gamebryolocalsavegames.cpp b/libs/game_bethesda/src/gamebryo/gamebryolocalsavegames.cpp index 4c1199c..2daf2c3 100644 --- a/libs/game_bethesda/src/gamebryo/gamebryolocalsavegames.cpp +++ b/libs/game_bethesda/src/gamebryo/gamebryolocalsavegames.cpp @@ -23,21 +23,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA #include #include -#include - #include "gamegamebryo.h" -// Helper to remove a key from a Bethesda-style INI file -static void removeIniValue(const QString& iniFile, const QString& section, - const QString& key) -{ - QSettings settings(iniFile, QSettings::IniFormat); - settings.beginGroup(section); - settings.remove(key); - settings.endGroup(); - settings.sync(); -} - GamebryoLocalSavegames::GamebryoLocalSavegames(const GameGamebryo* game, const QString& iniFileName) : m_Game{game}, m_IniFileName(iniFileName) @@ -119,20 +106,20 @@ bool GamebryoLocalSavegames::prepareProfile(MOBase::IProfile* profile) if (savedPath != "DELETE_ME") { MOBase::WriteRegistryValue("General", "sLocalSavePath", savedPath, iniFilePath); } else { - removeIniValue(iniFilePath, "General", "sLocalSavePath"); + MOBase::RemoveRegistryValue("General", "sLocalSavePath", iniFilePath); } if (savedMyGames != "DELETE_ME") { MOBase::WriteRegistryValue("General", "bUseMyGamesDirectory", savedMyGames, iniFilePath); } else { - removeIniValue(iniFilePath, "General", "bUseMyGamesDirectory"); + MOBase::RemoveRegistryValue("General", "bUseMyGamesDirectory", iniFilePath); } QFile::remove(saveIni); } // Otherwise just delete the setting else { - removeIniValue(iniFilePath, "General", "sLocalSavePath"); - removeIniValue(iniFilePath, "General", "bUseMyGamesDirectory"); + MOBase::RemoveRegistryValue("General", "sLocalSavePath", iniFilePath); + MOBase::RemoveRegistryValue("General", "bUseMyGamesDirectory", iniFilePath); } } -- cgit v1.3.1