From 3949dcfce95af4bd305f258ff5b170d7d50435f6 Mon Sep 17 00:00:00 2001
From: SulfurNitride <SulfurNitride@users.noreply.github.com>
Date: Sun, 12 Apr 2026 21:04:15 -0500
Subject: VFS perf fixes, icon/stylesheet compat, download filename fix

VFS:
- Open backing fd at mo2_open time for read-only handles so mo2_read can
  splice without re-opening the file on every read call.
- Bump RLIMIT_NOFILE at mount time to fit the resulting fd pressure when
  the game keeps hundreds of BSAs open.
- Dedicated node_cache_mutex so resolveByInode / mo2_lookup stop racing
  unordered_map writes while multiple tree_mutex readers are active.
- max_read=1MB + matching conn->max_read and raised max_readahead/max_write
  so the kernel merges Wine's small sequential reads into bigger FUSE
  requests.
- Per-op wall-clock counters in mo2_init() logs so we can distinguish VFS
  latency from game-side work.

Proton launch:
- Write dxvk.conf to the prefix and set DXVK_CONFIG_FILE to force
  dxvk.enableGraphicsPipelineLibrary=False, avoiding long GPL compile
  stalls on first run.

UI / plugin compat:
- Clamp IconDelegate's per-icon width to [8, 16] so narrow content
  columns don't trigger QIcon::pixmap(0,0) returning null and logging
  "failed to load icon" every repaint.
- Pre-create lowercase symlinks in the stylesheet directory so QSS files
  authored on Windows resolve url(foo.svg) when on-disk files are Foo.svg.
- Flip content icons empty-chessboard.png and facegen.png to 8-bit RGBA
  so Qt's built-in PNG reader loads them uniformly.
- Add mobase.Version.canonicalString shim for legacy Python plugins that
  still call the old VersionInfo method on appVersion()'s return.
- BSPluginList: compare normalized plugin name lists instead of byte
  hashes so the post-run case-fix refresh stops spuriously firing the
  "load order changed" dialog.
- BSPluginList disabled by default.

Download manager:
- Parse CDN URL with QUrl + QUrlQuery and read the filename from the
  response-content-disposition query param (RFC 6266 quoted / unquoted /
  ext-value forms), not QFileInfo on the raw URL.
- When the API or URL gives us a CDN object key (no archive extension),
  prefer the actual Content-Disposition header from the live response in
  metaDataChanged and downloadFinished.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../src/GUI/SelectionDialog.cpp                    | 102 +++++++++++++++++++++
 1 file changed, 102 insertions(+)
 create mode 100644 libs/installer_bsplugins/src/GUI/SelectionDialog.cpp

(limited to 'libs/installer_bsplugins/src/GUI/SelectionDialog.cpp')

diff --git a/libs/installer_bsplugins/src/GUI/SelectionDialog.cpp b/libs/installer_bsplugins/src/GUI/SelectionDialog.cpp
new file mode 100644
index 0000000..3572abe
--- /dev/null
+++ b/libs/installer_bsplugins/src/GUI/SelectionDialog.cpp
@@ -0,0 +1,102 @@
+#include "SelectionDialog.h"
+#include "ui_selectiondialog.h"
+
+#include <QCommandLinkButton>
+
+namespace GUI
+{
+
+SelectionDialog::SelectionDialog(const QString& description, QWidget* parent,
+                                 const QSize& iconSize)
+    : QDialog(parent), ui{new Ui::SelectionDialog}, m_Choice{nullptr},
+      m_ValidateByData{false}, m_IconSize{iconSize}
+{
+  ui->setupUi(this);
+
+  ui->descriptionLabel->setText(description);
+}
+
+SelectionDialog::~SelectionDialog() noexcept
+{
+  delete ui;
+}
+
+void SelectionDialog::addChoice(const QString& buttonText, const QString& description,
+                                const QVariant& data)
+{
+  QAbstractButton* button =
+      new QCommandLinkButton(buttonText, description, ui->buttonBox);
+  if (m_IconSize.isValid()) {
+    button->setIconSize(m_IconSize);
+  }
+  button->setProperty("data", data);
+  ui->buttonBox->addButton(button, QDialogButtonBox::AcceptRole);
+  if (data.isValid())
+    m_ValidateByData = true;
+}
+
+void SelectionDialog::addChoice(const QIcon& icon, const QString& buttonText,
+                                const QString& description, const QVariant& data)
+{
+  QAbstractButton* button =
+      new QCommandLinkButton(buttonText, description, ui->buttonBox);
+  if (m_IconSize.isValid()) {
+    button->setIconSize(m_IconSize);
+  }
+  button->setIcon(icon);
+  button->setProperty("data", data);
+  ui->buttonBox->addButton(button, QDialogButtonBox::AcceptRole);
+  if (data.isValid())
+    m_ValidateByData = true;
+}
+
+int SelectionDialog::numChoices() const
+{
+  return ui->buttonBox->findChildren<QCommandLinkButton*>(QString()).count();
+}
+
+QVariant SelectionDialog::getChoiceData()
+{
+  return m_Choice->property("data");
+}
+
+QString SelectionDialog::getChoiceString()
+{
+  if ((m_Choice == nullptr) ||
+      (m_ValidateByData && !m_Choice->property("data").isValid())) {
+    return QString();
+  } else {
+    return m_Choice->text();
+  }
+}
+
+QString SelectionDialog::getChoiceDescription()
+{
+  if (m_Choice == nullptr)
+    return QString();
+  else
+    return m_Choice->accessibleDescription();
+}
+
+void SelectionDialog::disableCancel()
+{
+  ui->cancelButton->setEnabled(false);
+  ui->cancelButton->setHidden(true);
+}
+
+void SelectionDialog::on_buttonBox_clicked(QAbstractButton* button)
+{
+  m_Choice = button;
+  if (!m_ValidateByData || m_Choice->property("data").isValid()) {
+    this->accept();
+  } else {
+    this->reject();
+  }
+}
+
+void SelectionDialog::on_cancelButton_clicked()
+{
+  this->reject();
+}
+
+}  // namespace GUI
-- 
cgit v1.3.1