From 3949dcfce95af4bd305f258ff5b170d7d50435f6 Mon Sep 17 00:00:00 2001 From: SulfurNitride Date: Sun, 12 Apr 2026 21:04:15 -0500 Subject: VFS perf fixes, icon/stylesheet compat, download filename fix VFS: - Open backing fd at mo2_open time for read-only handles so mo2_read can splice without re-opening the file on every read call. - Bump RLIMIT_NOFILE at mount time to fit the resulting fd pressure when the game keeps hundreds of BSAs open. - Dedicated node_cache_mutex so resolveByInode / mo2_lookup stop racing unordered_map writes while multiple tree_mutex readers are active. - max_read=1MB + matching conn->max_read and raised max_readahead/max_write so the kernel merges Wine's small sequential reads into bigger FUSE requests. - Per-op wall-clock counters in mo2_init() logs so we can distinguish VFS latency from game-side work. Proton launch: - Write dxvk.conf to the prefix and set DXVK_CONFIG_FILE to force dxvk.enableGraphicsPipelineLibrary=False, avoiding long GPL compile stalls on first run. UI / plugin compat: - Clamp IconDelegate's per-icon width to [8, 16] so narrow content columns don't trigger QIcon::pixmap(0,0) returning null and logging "failed to load icon" every repaint. - Pre-create lowercase symlinks in the stylesheet directory so QSS files authored on Windows resolve url(foo.svg) when on-disk files are Foo.svg. - Flip content icons empty-chessboard.png and facegen.png to 8-bit RGBA so Qt's built-in PNG reader loads them uniformly. - Add mobase.Version.canonicalString shim for legacy Python plugins that still call the old VersionInfo method on appVersion()'s return. - BSPluginList: compare normalized plugin name lists instead of byte hashes so the post-run case-fix refresh stops spuriously firing the "load order changed" dialog. - BSPluginList disabled by default. Download manager: - Parse CDN URL with QUrl + QUrlQuery and read the filename from the response-content-disposition query param (RFC 6266 quoted / unquoted / ext-value forms), not QFileInfo on the raw URL. - When the API or URL gives us a CDN object key (no archive extension), prefer the actual Content-Disposition header from the live response in metaDataChanged and downloadFinished. Co-Authored-By: Claude Opus 4.6 (1M context) --- libs/installer_bsplugins/src/TESData/FileInfo.cpp | 177 ++++++++++++++++++++++ 1 file changed, 177 insertions(+) create mode 100644 libs/installer_bsplugins/src/TESData/FileInfo.cpp (limited to 'libs/installer_bsplugins/src/TESData/FileInfo.cpp') diff --git a/libs/installer_bsplugins/src/TESData/FileInfo.cpp b/libs/installer_bsplugins/src/TESData/FileInfo.cpp new file mode 100644 index 0000000..8429a11 --- /dev/null +++ b/libs/installer_bsplugins/src/TESData/FileInfo.cpp @@ -0,0 +1,177 @@ +#include "FileInfo.h" +#include "FileEntry.h" +#include "MOPlugin/Settings.h" +#include "PluginList.h" + +#include + +using namespace Qt::Literals::StringLiterals; + +namespace TESData +{ + +FileInfo::FileInfo(PluginList* pluginList, const QString& name, bool forceLoaded, + bool forceEnabled, bool forceDisabled, bool lightSupported) + : m_PluginList{pluginList}, + m_FileSystemData{ + .name = name, + .hasMasterExtension = name.endsWith(u".esm"_s, Qt::CaseInsensitive), + .hasLightExtension = + lightSupported && name.endsWith(u".esl"_s, Qt::CaseInsensitive), + .forceLoaded = forceLoaded, + .forceEnabled = forceEnabled, + .forceDisabled = forceDisabled, + }, + m_Conflicts{[this]() { + return doConflictCheck(); + }} +{} + +bool FileInfo::isMasterFile() const +{ + return m_Metadata.isMasterFlagged || m_FileSystemData.hasMasterExtension || + m_FileSystemData.hasLightExtension; +} + +bool FileInfo::isMediumFile() const +{ + return m_Metadata.isMediumFlagged; +} + +bool FileInfo::isSmallFile() const +{ + return m_Metadata.isLightFlagged || m_FileSystemData.hasLightExtension; +} + +bool FileInfo::isBlueprintFile() const +{ + return isMasterFile() && m_Metadata.isBlueprintFlagged; +} + +bool FileInfo::isAlwaysEnabled() const +{ + return m_FileSystemData.forceLoaded || m_FileSystemData.forceEnabled; +} + +bool FileInfo::canBeToggled() const +{ + return !m_FileSystemData.forceLoaded && !m_FileSystemData.forceEnabled && + !m_FileSystemData.forceDisabled; +} + +bool FileInfo::mustLoadAfter(const FileInfo& other) const +{ + if (this->isBlueprintFile() && !other.isBlueprintFile()) { + return true; + } else if (other.isBlueprintFile() && !this->isBlueprintFile()) { + return false; + } + + const bool hasMaster = this->masters().contains(other.name(), Qt::CaseInsensitive); + const bool isMaster = other.masters().contains(this->name(), Qt::CaseInsensitive); + + if (hasMaster && !isMaster) { + return true; + } else if (isMaster) { + return false; + } + + if (other.forceLoaded() && !this->forceLoaded()) { + return true; + } + + if (other.isMasterFile() && !this->isMasterFile()) { + return true; + } + + return false; +} + +static void checkConflict(QSet& winning, QSet& losing, const FileInfo& file, + const TESData::PluginList* pluginList, + TESFileHandle alternative, bool ignoreMasters) +{ + const auto entry = pluginList->findEntryByName(file.name().toStdString()); + const auto otherEntry = pluginList->findEntryByHandle(alternative); + if (otherEntry == nullptr || otherEntry == entry) { + return; + } + + const auto otherFile = + pluginList->getPluginByName(QString::fromStdString(otherEntry->name())); + if (otherFile == nullptr) { + return; + } + + const QString otherName = QString::fromStdString(otherEntry->name()); + const int otherIndex = pluginList->getIndex(otherName); + + if (file.priority() > otherFile->priority()) { + if (!ignoreMasters || + !file.masters().contains(otherFile->name(), Qt::CaseInsensitive)) { + winning.insert(otherIndex); + } + } else { + if (!ignoreMasters || + !otherFile->masters().contains(file.name(), Qt::CaseInsensitive)) { + losing.insert(otherIndex); + } + } +} + +FileInfo::Conflicts FileInfo::doConflictCheck() const +{ + Conflicts conflicts; + + const auto entry = m_PluginList->findEntryByName(name().toStdString()); + if (entry == nullptr) { + return conflicts; + } + + const bool ignoreMasters = + Settings::instance()->get("ignore_master_conflicts", false); + + entry->forEachRecord([&](auto&& record) { + if (record->ignored()) + return; + + for (const auto alternative : record->alternatives()) { + checkConflict(conflicts.m_OverridingList, conflicts.m_OverriddenList, *this, + m_PluginList, alternative, ignoreMasters); + } + }); + + for (const auto& archive : m_FileSystemData.archives) { + const auto archiveEntry = m_PluginList->findArchive(archive); + if (!archiveEntry) { + continue; + } + + archiveEntry->forEachMember([&](auto&& item) { + for (const auto alternative : item->alternatives) { + checkConflict(conflicts.m_OverwritingArchiveList, + conflicts.m_OverwrittenArchiveList, *this, m_PluginList, + alternative, ignoreMasters); + } + }); + } + + uint conflictState = CONFLICT_NONE; + if (!conflicts.m_OverridingList.empty()) { + conflictState |= CONFLICT_OVERRIDE; + } + if (!conflicts.m_OverriddenList.empty()) { + conflictState |= CONFLICT_OVERRIDDEN; + } + if (!conflicts.m_OverwritingArchiveList.empty()) { + conflictState |= CONFLICT_ARCHIVE_OVERWRITE; + } + if (!conflicts.m_OverwrittenArchiveList.empty()) { + conflictState |= CONFLICT_ARCHIVE_OVERWRITTEN; + } + conflicts.m_CurrentConflictState = static_cast(conflictState); + + return conflicts; +} + +} // namespace TESData -- cgit v1.3.1