From 84a43a2e6afbdfab92c610d47aa75e3876ffacd6 Mon Sep 17 00:00:00 2001 From: SulfurNitride Date: Thu, 12 Mar 2026 13:48:25 -0500 Subject: Replace wrestool with native Rust PE icon extraction (pelite) - Add icons.rs to nak crate: parses PE resource sections, extracts RT_GROUP_ICON/RT_ICON and builds ICO files in memory - Expose nak_extract_exe_icon() FFI for C++ consumption - Update iconForExecutable() to use Rust FFI instead of shelling out to wrestool; reads all ICO entries for correct color depth - Fix BasicGamePlugin::gameIcon() to call iconForExecutable() (was returning empty QIcon, causing placeholder icons for BG3/Cyberpunk) - Move app icon setup: setDesktopFileName + setWindowIcon to MOApplication constructor (fixes Wayland taskbar/decoration icon) - Move data/com.fluorine.* to data/icons/, install to XDG paths at launch for Wayland compositor icon resolution - Remove icoutils dependency from Docker image and build output Co-Authored-By: Claude Opus 4.6 --- libs/nak_ffi/include/nak_ffi.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'libs/nak_ffi/include') diff --git a/libs/nak_ffi/include/nak_ffi.h b/libs/nak_ffi/include/nak_ffi.h index cc66d9e..e1a9185 100644 --- a/libs/nak_ffi/include/nak_ffi.h +++ b/libs/nak_ffi/include/nak_ffi.h @@ -175,6 +175,23 @@ char *nak_ensure_dxvk_conf(void); * Returns newly allocated string (free with nak_string_free). */ char *nak_get_dxvk_conf_path(void); +/* ======================================================================== + * Tier 8: PE Icon Extraction + * ======================================================================== */ + +/** Result of icon extraction */ +typedef struct { + uint8_t *data; /**< Raw ICO file bytes (NULL if extraction failed) */ + size_t len; /**< Length in bytes (0 if extraction failed) */ +} NakIconData; + +/** Extract the best icon from a Windows PE executable (.exe/.dll). + * Returns raw ICO bytes. Free with nak_icon_data_free(). */ +NakIconData nak_extract_exe_icon(const char *exe_path); + +/** Free icon data returned by nak_extract_exe_icon */ +void nak_icon_data_free(NakIconData icon); + /* ======================================================================== * General * ======================================================================== */ -- cgit v1.3.1