From e1c8d00979793dd00a90d312ccdd275cf48dc4ad Mon Sep 17 00:00:00 2001
From: Tom Tanner <thosrtanner2@users.sourceforge.net>
Date: Sat, 18 Jul 2015 13:34:10 +0100
Subject: Reworked executable lists to not use 3 bools in addExecutable

Think it's more readable
---
 src/executableslist.h | 49 +++++++++++++++++++++++++++++++++++--------------
 1 file changed, 35 insertions(+), 14 deletions(-)

(limited to 'src/executableslist.h')

diff --git a/src/executableslist.h b/src/executableslist.h
index 8eda38f5..4e1ad644 100644
--- a/src/executableslist.h
+++ b/src/executableslist.h
@@ -39,9 +39,32 @@ struct Executable {
   QString m_SteamAppID;
   QString m_WorkingDirectory;
 
-  bool m_Custom;
-  bool m_Toolbar;
-  bool m_UseOwnIcon;
+  enum class Type {
+    Game,
+    Custom
+  };
+
+  enum class Toolbar {
+    Disabled,
+    Enabled
+  };
+
+  enum class Icon {
+    MO,
+    Application
+  };
+
+  Type m_Type;
+  Toolbar m_Toolbar;
+  Icon m_Icon;
+
+  bool isCustom() const { return m_Type == Type::Custom; }
+
+  bool shownOnToolbar() const { return m_Toolbar == Toolbar::Enabled; }
+
+  void showOnToolbar(bool state) { m_Toolbar = state ? Toolbar::Enabled : Toolbar::Disabled; }
+
+  bool usesOwnIcon() const { return m_Icon == Icon::Application; }
 };
 
 
@@ -120,17 +143,15 @@ public:
    * @param arguments arguments to pass to the executable
    * @param closeMO if true, MO will be closed when the binary is started
    **/
-  void addExecutable(const QString &title, const QString &executableName, const QString &arguments,
-                     const QString &workingDirectory, MOBase::ExecutableInfo::CloseMOStyle closeMO, const QString &steamAppID,
-                     bool custom, bool toolbar, bool ownicon);
-
-  /**
-   * @brief change position of an executable which is expected to exist
-   * @param title title of the executable
-   * @param toolbar enable/disable placement on the toolbar
-   * @param pos new position for the executable
-   */
-  void position(const QString &title, bool toolbar, int pos);
+  void addExecutable(const QString &title,
+                     const QString &executableName,
+                     const QString &arguments,
+                     const QString &workingDirectory,
+                     MOBase::ExecutableInfo::CloseMOStyle closeMO,
+                     const QString &steamAppID,
+                     Executable::Type custom,
+                     Executable::Toolbar toolbar,
+                     Executable::Icon ownicon);
 
   /**
    * @brief remove the executable with the specified file name. This needs to be an absolute file path
-- 
cgit v1.3.1