From 48274f33579076711c0475e84c7adf68c52df733 Mon Sep 17 00:00:00 2001
From: isanae <14251494+isanae@users.noreply.github.com>
Date: Fri, 12 Feb 2021 03:22:52 -0500
Subject: - renamed instance::name() to displayName() to reduce confusion with
 portable instances - better errors when running incorrect shortcuts - fixed
 shortcuts being created with moshortcut://Portable:exe instead of an empty
 instance name for portable instances

---
 src/instancemanager.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'src/instancemanager.h')

diff --git a/src/instancemanager.h b/src/instancemanager.h
index 893b88e4..f1781a70 100644
--- a/src/instancemanager.h
+++ b/src/instancemanager.h
@@ -132,9 +132,14 @@ public:
   // returns the instance name; this is the directory name or "Portable" for
   // portable instances
   //
+  // be careful when using this function to check whether two instances are the
+  // same, some parts of MO use an empty string to represent portable instances,
+  // but this function will return "Portable" for them; it's safer to check
+  // for isPortable() first
+  //
   // can be called without setup()
   //
-  QString name() const;
+  QString displayName() const;
 
   // returns either:
   //   1) the game name from the INI, if readFromIni() was called;
-- 
cgit v1.3.1