From 0da1c2591f0a67560b241515d996c39598da6735 Mon Sep 17 00:00:00 2001
From: isanae <14251494+isanae@users.noreply.github.com>
Date: Fri, 31 May 2019 13:09:17 -0400
Subject: don't show open menu item if the files are from an archive

---
 src/modinfodialog.cpp | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

(limited to 'src/modinfodialog.cpp')

diff --git a/src/modinfodialog.cpp b/src/modinfodialog.cpp
index e639dcc7..97507777 100644
--- a/src/modinfodialog.cpp
+++ b/src/modinfodialog.cpp
@@ -2000,6 +2000,12 @@ bool ModInfoDialog::canPreviewFile(bool isArchive, const QString& filename) cons
   return m_PluginContainer->previewGenerator().previewSupported(ext);
 }
 
+bool ModInfoDialog::canOpenFile(bool isArchive, const QString&) const
+{
+  // can open anything as long as it's not in an archive
+  return !isArchive;
+}
+
 bool ModInfoDialog::canHideFile(bool isArchive, const QString& filename) const
 {
   if (isArchive) {
@@ -2040,6 +2046,11 @@ bool ModInfoDialog::canUnhideConflictItem(const QTreeWidgetItem* item) const
   return canUnhideFile(conflictIsArchive(item), conflictFileName(item));
 }
 
+bool ModInfoDialog::canOpenConflictItem(const QTreeWidgetItem* item) const
+{
+  return canOpenFile(conflictIsArchive(item), conflictFileName(item));
+}
+
 bool ModInfoDialog::canPreviewConflictItem(const QTreeWidgetItem* item) const
 {
   return canPreviewFile(conflictIsArchive(item), conflictFileName(item));
@@ -2131,8 +2142,8 @@ ModInfoDialog::ConflictActions ModInfoDialog::createConflictMenuActions(
 
     enableHide = canHideConflictItem(item);
     enableUnhide = canUnhideConflictItem(item);
+    enableOpen = canOpenConflictItem(item);
     enablePreview = canPreviewConflictItem(item);
-    // open is always enabled
   }
   else {
     // this is a multiple selection, don't show open/preview so users don't open
-- 
cgit v1.3.1