From 971f890826412994a56fc1b37b10d3bf21e1275d Mon Sep 17 00:00:00 2001
From: isanae <14251494+isanae@users.noreply.github.com>
Date: Tue, 2 Jul 2019 14:36:59 -0400
Subject: some refactoring updateTabs() creates a list of tabs to update
 instead of checking for each file comments

---
 src/modinfodialog.h | 55 ++++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 44 insertions(+), 11 deletions(-)

(limited to 'src/modinfodialog.h')

diff --git a/src/modinfodialog.h b/src/modinfodialog.h
index 035eb6d6..34555b0c 100644
--- a/src/modinfodialog.h
+++ b/src/modinfodialog.h
@@ -141,9 +141,9 @@ private:
   bool m_arrangingTabs;
 
 
-  // creates all the tabs
+  // creates all the tabs and connects events
   //
-  std::vector<TabInfo> createTabs();
+  void createTabs();
 
 
   // sets the currently selected mod; resets first activation, but doesn't
@@ -155,17 +155,16 @@ private:
   //
   void setMod(const QString& name);
 
+  // returns the origin of the current mod, may be null
+  //
+  MOShared::FilesOrigin* getOrigin();
+
 
   // returns the currently selected tab, taking re-ordering in to account;
   // shouldn't be null, but could be
   //
   TabInfo* currentTab();
 
-  // returns a list of tab object names in their visual order, used by
-  // saveState()
-  //
-  void saveTabOrder(Settings& s) const;
-
 
   // fully updates the dialog; sets the title, the tab visibility and updates
   // all the tabs; used when the current mod changes
@@ -179,16 +178,50 @@ private:
   void setTabsVisibility(bool firstTime);
 
   // clears the tab widgets and re-adds the tabs having the visible flag in
-  // the given vector, following the
+  // the given vector, following the tab order from the settings
+  //
   void reAddTabs(const std::vector<bool>& visibility, ModInfoTabIDs sel);
 
-  void onDeleteShortcut();
-  MOShared::FilesOrigin* getOrigin();
+  // called by update(); clears tabs, feeds files and calls update() on all
+  // tabs, then setTabsColors()
+  //
   void updateTabs(bool becauseOriginChanged=false);
-  void feedFiles(bool becauseOriginChanged);
+
+  // goes through all files on the filesystem for the current mod and calls
+  // feedFile() on every tab until one accepts it
+  //
+  void feedFiles(std::vector<TabInfo*>& interestedTabs);
+
+  // goes through all tabs and sets the tab text colour depending on whether
+  // they have data or not
+  //
   void setTabsColors();
+
+
+  // called when the delete key is pressed anywhere in the dialog; forwards to
+  // ModInfoDialogTab::deleteRequest() for the currently selected tab
+  //
+  void onDeleteShortcut();
+
+
+  // finds the tab with the given id and selects it
+  //
   void switchToTab(ModInfoTabIDs id);
+
+
+  // saves the current tab order; used by saveState(), but also by
+  // setTabsVisibility() to make sure any changes to order are saved before
+  // re-adding tabs
+  //
+  void saveTabOrder(Settings& s) const;
+
+  // returns a list of tab names in the order they should appear on the widget
+  //
   std::vector<QString> getOrderedTabNames() const;
+
+  // asks all the tabs if they accept closing the dialog, returns false if one
+  // objected
+  //
   bool tryClose();
 
 
-- 
cgit v1.3.1