From c5e3fb423fd144faa2db8f2bb156adba6c003d39 Mon Sep 17 00:00:00 2001 From: AL <26797547+Al12rs@users.noreply.github.com> Date: Mon, 2 Nov 2020 23:20:43 +0100 Subject: Change some for loops to use refs, prefer range loop where possible. --- src/modinfowithconflictinfo.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/modinfowithconflictinfo.cpp') diff --git a/src/modinfowithconflictinfo.cpp b/src/modinfowithconflictinfo.cpp index 3db41147..24c154e6 100644 --- a/src/modinfowithconflictinfo.cpp +++ b/src/modinfowithconflictinfo.cpp @@ -154,7 +154,7 @@ void ModInfoWithConflictInfo::doConflictCheck() const if (file->getOrigin() == origin.getID()) archiveData = file->getArchive(); else { - for (auto alt : alternatives) { + for (const auto& alt : alternatives) { if (alt.originID() == origin.getID()) { archiveData = alt.archive(); break; @@ -180,7 +180,7 @@ void ModInfoWithConflictInfo::doConflictCheck() const } // Sort out the alternatives - for (auto altInfo : alternatives) { + for (const auto& altInfo : alternatives) { if ((altInfo.originID() != dataID) && (altInfo.originID() != origin.getID())) { FilesOrigin &altOrigin = (*m_DirectoryStructure)->getOriginByID(altInfo.originID()); QString altOriginName = ToQString(altOrigin.getName()); -- cgit v1.3.1