From 69ff53f4433da1b062aefe5a4654ed155092ac7a Mon Sep 17 00:00:00 2001 From: Al12rs Date: Sat, 22 Dec 2018 16:41:05 +0100 Subject: Some logging for drop events on modlist. --- src/modlist.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'src/modlist.cpp') diff --git a/src/modlist.cpp b/src/modlist.cpp index 16d2cd07..b1605eb0 100644 --- a/src/modlist.cpp +++ b/src/modlist.cpp @@ -949,7 +949,6 @@ bool ModList::dropURLs(const QMimeData *mimeData, int row, const QModelIndex &pa if (row == -1) { row = parent.row(); } - ModInfo::Ptr modInfo = ModInfo::getByIndex(row); QDir modDirectory(modInfo->absolutePath()); QDir gameDirectory(Settings::instance().getOverwriteDirectory()); @@ -961,12 +960,14 @@ bool ModList::dropURLs(const QMimeData *mimeData, int row, const QModelIndex &pa QString overwriteName = ModInfo::getByIndex(overwriteIndex)->name(); for (const QUrl &url : mimeData->urls()) { + qDebug("URL drop requested: %s", qPrintable(url.toLocalFile())); if (!url.isLocalFile()) { + qDebug("URL drop ignored: Not a local file."); continue; } QString relativePath = gameDirectory.relativeFilePath(url.toLocalFile()); if (relativePath.startsWith("..")) { - qDebug("%s drop ignored", qPrintable(url.toLocalFile())); + qDebug("URL drop ignored: relative path starts with .."); continue; } source.append(url.toLocalFile()); @@ -975,7 +976,10 @@ bool ModList::dropURLs(const QMimeData *mimeData, int row, const QModelIndex &pa } if (source.count() != 0) { - shellMove(source, target); + if (!shellMove(source, target)) { + qDebug("Move failed %lu",::GetLastError()); + return false; + } } return true; -- cgit v1.3.1 From 77e4cb5c6edcd79b0d0652a23ebc009c81fabf03 Mon Sep 17 00:00:00 2001 From: Al12rs Date: Sat, 22 Dec 2018 17:02:55 +0100 Subject: Improved tooltip for Alternate Game Source flag. --- src/modlist.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/modlist.cpp') diff --git a/src/modlist.cpp b/src/modlist.cpp index b1605eb0..b903b22b 100644 --- a/src/modlist.cpp +++ b/src/modlist.cpp @@ -162,7 +162,7 @@ QString ModList::getFlagText(ModInfo::EFlag flag, ModInfo::Ptr modInfo) const case ModInfo::FLAG_CONFLICT_OVERWRITTEN: return tr("Overwritten files"); case ModInfo::FLAG_CONFLICT_MIXED: return tr("Overwrites & Overwritten"); case ModInfo::FLAG_CONFLICT_REDUNDANT: return tr("Redundant"); - case ModInfo::FLAG_ALTERNATE_GAME: return tr("Alternate game source"); + case ModInfo::FLAG_ALTERNATE_GAME: return tr("This mod is targetting a different game"); default: return ""; } } -- cgit v1.3.1 From 2d79e37e59cf9c38b08250baa1f0e6e7f7b70545 Mon Sep 17 00:00:00 2001 From: Al12rs Date: Sat, 22 Dec 2018 17:06:06 +0100 Subject: Fixed typo in previous commit. --- src/modlist.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/modlist.cpp') diff --git a/src/modlist.cpp b/src/modlist.cpp index b903b22b..2cb74d50 100644 --- a/src/modlist.cpp +++ b/src/modlist.cpp @@ -162,7 +162,7 @@ QString ModList::getFlagText(ModInfo::EFlag flag, ModInfo::Ptr modInfo) const case ModInfo::FLAG_CONFLICT_OVERWRITTEN: return tr("Overwritten files"); case ModInfo::FLAG_CONFLICT_MIXED: return tr("Overwrites & Overwritten"); case ModInfo::FLAG_CONFLICT_REDUNDANT: return tr("Redundant"); - case ModInfo::FLAG_ALTERNATE_GAME: return tr("This mod is targetting a different game"); + case ModInfo::FLAG_ALTERNATE_GAME: return tr("This mod targets a different game"); default: return ""; } } -- cgit v1.3.1