From dfca8be71b15bc13997110cc8777dd5a84a1fde7 Mon Sep 17 00:00:00 2001
From: Tannin <devnull@localhost>
Date: Sat, 21 Sep 2013 19:25:33 +0200
Subject: - esp reader now handles invalid files more gracefully - files moved
 will now also be treated as "deleted" in the old location so a newly created
 file with that same name is not created in overwrite - introduced a mechanism
 by which MO can recognize if it crashed before when attempting to load a
 plugin. That plugin can be blacklisted so it doesn't get loaded again -
 plugins can now programaticaly change their settings - plugins can now store
 data persistently without exposing that data as settings - requesting an
 unset-setting from a plugin is no longer treated as a bug - clarified warning
 message for when files are in overwrite directory - the proxyPython plugin
 will now discover if python initialization crashed MO on a previous session
 and give the user a chance to fix it or disable the plugin - bugfix:
 GetModuleFileName modified the buffer past the zero termination. While this
 doesn't violate the API documentation it is different from the regular
 windows implementation - bugfix: proxy plugins couldn't access the parent
 widget - bugfix: when moving a file from overwrite to a mod the in-memory
 file structure wasn't updated - bugfix: name input dialog for profiles
 allowed names that weren't valid directory names - bugfix: profile dialog
 wasn't able to delete profiles if the name started or ended in whitespaces -
 bugfix: The name-cells for plugin settings could be changed (without effect)
 - removed a few obsolete files from the repository

---
 src/profilesdialog.cpp | 47 +++++++++++++++++++++++++++++++++--------------
 1 file changed, 33 insertions(+), 14 deletions(-)

(limited to 'src/profilesdialog.cpp')

diff --git a/src/profilesdialog.cpp b/src/profilesdialog.cpp
index 9955ecd2..69872a24 100644
--- a/src/profilesdialog.cpp
+++ b/src/profilesdialog.cpp
@@ -150,36 +150,55 @@ void ProfilesDialog::on_copyProfileButton_clicked()
 {
   bool okClicked;
   QString name = QInputDialog::getText(this, tr("Name"), tr("Please enter a name for the new profile"), QLineEdit::Normal, QString(), &okClicked);
-  if (okClicked && (name.size() > 0)) {
-    QListWidget *profilesList = findChild<QListWidget*>("profilesList");
-
-    try {
-      const Profile::Ptr currentProfile = profilesList->currentItem()->data(Qt::UserRole).value<Profile::Ptr>();
-      createProfile(name, *currentProfile);
-    } catch (const std::exception &e) {
-      reportError(tr("failed to copy profile: %1").arg(e.what()));
+  fixDirectoryName(name);
+  if (okClicked) {
+    if (name.size() > 0) {
+      QListWidget *profilesList = findChild<QListWidget*>("profilesList");
+
+      try {
+        const Profile::Ptr currentProfile = profilesList->currentItem()->data(Qt::UserRole).value<Profile::Ptr>();
+        createProfile(name, *currentProfile);
+      } catch (const std::exception &e) {
+        reportError(tr("failed to copy profile: %1").arg(e.what()));
+      }
+    } else {
+      QMessageBox::warning(this, tr("Invalid name"), tr("Invalid profile name"));
     }
   }
 }
 
 void ProfilesDialog::on_removeProfileButton_clicked()
 {
-  QMessageBox confirmBox(QMessageBox::Question, tr("Confirm"), tr("Are you sure you want to remove this profile?"),
+  QMessageBox confirmBox(QMessageBox::Question, tr("Confirm"), tr("Are you sure you want to remove this profile (including local savegames if any)?"),
                          QMessageBox::Yes | QMessageBox::No);
 
   if (confirmBox.exec() == QMessageBox::Yes) {
     QListWidget *profilesList = findChild<QListWidget*>("profilesList");
 
     Profile::Ptr currentProfile = profilesList->currentItem()->data(Qt::UserRole).value<Profile::Ptr>();
-
-    // on destruction, the profile object would write the profile.ini file again, so
-    // we have to get rid of the it before deleting the directory
-    QString profilePath = currentProfile->getPath();
+    QString profilePath;
+    if (currentProfile.get() == NULL) {
+      profilePath = QDir::fromNativeSeparators(ToQString(GameInfo::instance().getProfilesDir())) + "/" + profilesList->currentItem()->text();
+      if (QMessageBox::question(this, tr("Profile broken"),
+            tr("This profile you're about to delete seems to be broken or the path is invalid. "
+            "I'm about to delete the following folder: \"%1\". Proceed?").arg(profilePath), QMessageBox::Yes | QMessageBox::No) == QMessageBox::No) {
+        return;
+      }
+    } else {
+      // on destruction, the profile object would write the profile.ini file again, so
+      // we have to get rid of the it before deleting the directory
+      profilePath = currentProfile->getPath();
+    }
     QListWidgetItem* item = profilesList->takeItem(profilesList->currentRow());
     if (item != NULL) {
       delete item;
     }
-    shellDelete(QStringList(profilePath));
+    if (!shellDelete(QStringList(profilePath))) {
+      qWarning("Failed to shell-delete \"%s\" (errorcode %lu), trying regular delete", qPrintable(profilePath), ::GetLastError());
+      if (!removeDir(profilePath)) {
+        qWarning("regular delete failed too");
+      }
+    }
   }
 }
 
-- 
cgit v1.3.1