From 03608230acd0faa7d5fefdc11c75713a0b6c733e Mon Sep 17 00:00:00 2001 From: LePresidente Date: Mon, 23 Oct 2017 18:33:42 +0200 Subject: added a catch all for the remote version check when checking for updates. Should stop a hard crash but should probably be reviewed at a date. --- src/selfupdater.cpp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/selfupdater.cpp') diff --git a/src/selfupdater.cpp b/src/selfupdater.cpp index d78b020b..273e9b45 100644 --- a/src/selfupdater.cpp +++ b/src/selfupdater.cpp @@ -124,6 +124,7 @@ void SelfUpdater::testForUpdate() { // TODO: if prereleases are disabled we could just request the latest release // directly + try { m_GitHub.releases(GitHub::Repository("LePresidente", "modorganizer"), [this](const QJsonArray &releases) { QJsonObject newest; @@ -155,6 +156,11 @@ void SelfUpdater::testForUpdate() } } }); + } + //Catch all is bad by design, should be improved + catch (...) { + qDebug("Unable to connect to github.com to check version"); + } } void SelfUpdater::startUpdate() -- cgit v1.3.1