From 42d8bba5d419d13fcc6334c9bd73cb3c3a6d5251 Mon Sep 17 00:00:00 2001
From: Silarn <jrim@rimpo.org>
Date: Thu, 31 Jan 2019 14:10:09 -0600
Subject: Stop blindly following examples and use better code

---
 src/settings.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

(limited to 'src/settings.cpp')

diff --git a/src/settings.cpp b/src/settings.cpp
index 1d5da376..80d429c3 100644
--- a/src/settings.cpp
+++ b/src/settings.cpp
@@ -181,7 +181,7 @@ QString Settings::obfuscate(const QString &info)
   QString result;
   DATA_BLOB input;
   DATA_BLOB output;
-  BYTE *pbInput = (unsigned char *)malloc(info.size() + 1);
+  BYTE *pbInput = new unsigned char[info.size() + 1];
   memcpy(pbInput, info.constData(), info.size() + 1);
   DWORD cbInput = info.size() + 1;
   input.pbData = pbInput;
@@ -193,8 +193,8 @@ QString Settings::obfuscate(const QString &info)
   } else {
     qCritical() << "Failed to encrypt the data!";
   }
-  LocalFree(input.pbData);
-  LocalFree(output.pbData);
+  delete pbInput;
+  delete output.pbData;
   return result;
 }
 
@@ -204,7 +204,7 @@ QString Settings::deObfuscate(const QString &info)
   QByteArray realInfo = QByteArray::fromBase64(info.toUtf8());
   DATA_BLOB input;
   DATA_BLOB output;
-  BYTE *pbInput = (unsigned char *)malloc(realInfo.size() + 1);
+  BYTE *pbInput = new unsigned char[realInfo.size() + 1];
   memcpy(pbInput, realInfo.constData(), realInfo.size() + 1);
   DWORD cbInput = realInfo.size() + 1;
   input.pbData = pbInput;
@@ -216,8 +216,8 @@ QString Settings::deObfuscate(const QString &info)
   } else {
     qCritical() << "Failed to decrypt data!";
   }
-  LocalFree(input.pbData);
-  LocalFree(output.pbData);
+  delete pbInput;
+  delete output.pbData;
   return result;
 }
 
-- 
cgit v1.3.1