From 9c9a43ec8da94a374e4a8ea3a7a5cfd2de341162 Mon Sep 17 00:00:00 2001 From: Eran Mizrahi Date: Tue, 26 Dec 2017 21:03:57 +0200 Subject: print settings loading and changes to log for diagnostic purposes --- src/settings.cpp | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'src/settings.cpp') diff --git a/src/settings.cpp b/src/settings.cpp index b2fc8939..028f88da 100644 --- a/src/settings.cpp +++ b/src/settings.cpp @@ -601,10 +601,31 @@ void Settings::query(QWidget *parent) tabs.push_back(std::unique_ptr(new WorkaroundsTab(this, dialog))); if (dialog.exec() == QDialog::Accepted) { + // remember settings before change + QMap before; + m_Settings.beginGroup("Settings"); + for (auto k : m_Settings.allKeys()) + before[k] = m_Settings.value(k).toString(); + m_Settings.endGroup(); + // transfer modified settings to configuration file for (std::unique_ptr const &tab: tabs) { tab->update(); } + + // print "changed" settings + m_Settings.beginGroup("Settings"); + bool first_update = true; + for (auto k : m_Settings.allKeys()) + if (m_Settings.value(k).toString() != before[k]) + { + if (first_update) { + qDebug("Changed settings:"); + first_update = false; + } + qDebug(" %s=%s", k.toUtf8().data(), m_Settings.value(k).toString().toUtf8().data()); + } + m_Settings.endGroup(); } } -- cgit v1.3.1 From 548744d746223f0f96b33587ca41d2ed6a314f33 Mon Sep 17 00:00:00 2001 From: Eran Mizrahi Date: Wed, 27 Dec 2017 04:18:46 +0200 Subject: Don't log username and password --- src/main.cpp | 3 ++- src/settings.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'src/settings.cpp') diff --git a/src/main.cpp b/src/main.cpp index 5418abc2..4c5ac75c 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -447,7 +447,8 @@ int runApplication(MOApplication &application, SingleInstance &instance, qDebug("Loaded settings:"); settings.beginGroup("Settings"); for (auto k : settings.allKeys()) - qDebug(" %s=%s", k.toUtf8().data(), settings.value(k).toString().toUtf8().data()); + if (!k.contains("username") && !k.contains("password")) + qDebug(" %s=%s", k.toUtf8().data(), settings.value(k).toString().toUtf8().data()); settings.endGroup(); diff --git a/src/settings.cpp b/src/settings.cpp index 028f88da..d1130e05 100644 --- a/src/settings.cpp +++ b/src/settings.cpp @@ -617,7 +617,7 @@ void Settings::query(QWidget *parent) m_Settings.beginGroup("Settings"); bool first_update = true; for (auto k : m_Settings.allKeys()) - if (m_Settings.value(k).toString() != before[k]) + if (m_Settings.value(k).toString() != before[k] && !k.contains("username") && !k.contains("password")) { if (first_update) { qDebug("Changed settings:"); -- cgit v1.3.1