diff options
| author | SulfurNitride <SulfurNitride@users.noreply.github.com> | 2026-04-23 19:37:07 -0500 |
|---|---|---|
| committer | SulfurNitride <SulfurNitride@users.noreply.github.com> | 2026-04-23 19:37:07 -0500 |
| commit | b36a4f0c564d777f82b24a36a265b37ffbeafd2d (patch) | |
| tree | 2b396ec0038a52a67a6c4f97a688108597a2f948 /.github | |
| parent | ce6b7aabe6a52367e882251015c2d263108ecd43 (diff) | |
Fix Updates tab compile + CI failure propagation
- settingsdialogupdates.cpp missed an include of settings.h (it was only
getting the forward-declared version from settingsdialog.h), which
broke every settings().setX() call. Now included directly.
- UpdatesSettingsTab is not a QObject so it has no tr() member; add
Q_DECLARE_TR_FUNCTIONS to get a static tr() via QCoreApplication.
- CI: the docker run chained commands with `;` so a ninja failure got
masked by the trailing `ccache -s`. Capture the build-inner.sh exit
status and `exit $status` at the end so real build failures fail the
step instead of bleeding into the tar packaging step and producing a
confusing "Cannot stat: No such file" error.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/ci.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 757909e..0525c28 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -71,7 +71,7 @@ jobs: -e FLUORINE_BUILD_COMMIT=${{ steps.channel.outputs.commit }} \ -w /src \ fluorine-builder:latest \ - bash -c 'ccache -s; bash /src/docker/build-inner.sh; echo "=== ccache stats after build ==="; ccache -s' + bash -c 'ccache -s; bash /src/docker/build-inner.sh; status=$?; echo "=== ccache stats after build ==="; ccache -s; exit $status' - name: Package tarball run: | |