aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSulfurNitride <SulfurNitride@users.noreply.github.com>2026-04-23 19:37:07 -0500
committerSulfurNitride <SulfurNitride@users.noreply.github.com>2026-04-23 19:37:07 -0500
commitb36a4f0c564d777f82b24a36a265b37ffbeafd2d (patch)
tree2b396ec0038a52a67a6c4f97a688108597a2f948 /src
parentce6b7aabe6a52367e882251015c2d263108ecd43 (diff)
Fix Updates tab compile + CI failure propagation
- settingsdialogupdates.cpp missed an include of settings.h (it was only getting the forward-declared version from settingsdialog.h), which broke every settings().setX() call. Now included directly. - UpdatesSettingsTab is not a QObject so it has no tr() member; add Q_DECLARE_TR_FUNCTIONS to get a static tr() via QCoreApplication. - CI: the docker run chained commands with `;` so a ninja failure got masked by the trailing `ccache -s`. Capture the build-inner.sh exit status and `exit $status` at the end so real build failures fail the step instead of bleeding into the tar packaging step and producing a confusing "Cannot stat: No such file" error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src')
-rw-r--r--src/src/settingsdialogupdates.cpp1
-rw-r--r--src/src/settingsdialogupdates.h3
2 files changed, 4 insertions, 0 deletions
diff --git a/src/src/settingsdialogupdates.cpp b/src/src/settingsdialogupdates.cpp
index b46ff1e..c5441d1 100644
--- a/src/src/settingsdialogupdates.cpp
+++ b/src/src/settingsdialogupdates.cpp
@@ -1,6 +1,7 @@
#include "settingsdialogupdates.h"
#include "fluorineupdater.h"
+#include "settings.h"
#include "ui_settingsdialog.h"
#include <fluorine_build_info.h>
diff --git a/src/src/settingsdialogupdates.h b/src/src/settingsdialogupdates.h
index 7a39311..9712beb 100644
--- a/src/src/settingsdialogupdates.h
+++ b/src/src/settingsdialogupdates.h
@@ -3,6 +3,8 @@
#include "settingsdialog.h"
+#include <QCoreApplication>
+
class QCheckBox;
class QComboBox;
class QLabel;
@@ -15,6 +17,7 @@ class FluorineUpdater;
// "Check for updates now" button with live status feedback.
class UpdatesSettingsTab : public SettingsTab
{
+ Q_DECLARE_TR_FUNCTIONS(UpdatesSettingsTab)
public:
UpdatesSettingsTab(Settings& settings, SettingsDialog& dialog);