diff options
| author | Brian Munro <brian.alexander.munro@gmail.com> | 2018-08-22 06:38:34 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-22 06:38:34 +0200 |
| commit | 2232bdfc779b8575c8374a723d4d02a2b41fb352 (patch) | |
| tree | 858aa93a1d01f0187927fcf908978ab3e86e4c2c /src/downloadmanager.cpp | |
| parent | 364289db72ca452e7af56dbf6ff43d0573656e57 (diff) | |
| parent | 258bddb6b761365c1b4688d5f91885c14f2b1efc (diff) | |
Merge pull request #497 from Modorganizer2/Develop
Fix possible crash during write to disk error
Diffstat (limited to 'src/downloadmanager.cpp')
| -rw-r--r-- | src/downloadmanager.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/downloadmanager.cpp b/src/downloadmanager.cpp index 1e907b3f..f1cbf109 100644 --- a/src/downloadmanager.cpp +++ b/src/downloadmanager.cpp @@ -1845,11 +1845,12 @@ void DownloadManager::writeData(DownloadInfo *info) if (info != nullptr) {
qint64 ret = info->m_Output.write(info->m_Reply->readAll());
if (ret < info->m_Reply->size()) {
+ QString fileName = info->m_FileName; // m_FileName may be destroyed after setState
setState(info, DownloadState::STATE_CANCELED);
qCritical(QString("Unable to write download \"%2\" to drive (return %1)").arg(ret).arg(info->m_FileName).toLocal8Bit());
reportError(tr("Unable to write download to drive (return %1).\n"
"Check the drive's available storage.\n\n"
- "Canceling download \"%2\"...").arg(ret).arg(info->m_FileName));
+ "Canceling download \"%2\"...").arg(ret).arg(fileName));
}
}
}
\ No newline at end of file |