- some fixes for qt5 compatibility

- hook.dll no longer creates a dump and uninstalls it if an exception is reported that doesn't originate from it
- NCC used read-only transactions again because otherwise solid archives become unusably slow.
- removed the integrated nexus browser
- the mod description and motd are now rendered in QTextBrowser. This (and the above) eliminates the dependency on qtwebkit
- removed the direct file download for mod files
- reduced CPU usage during downloads by invalidating only one column of the download list. This widget still needs to be replaced
- added the complete filename as an option for the modname
- applications that require elevation can now be started by invoking an elevated secondary ModOrganizer instance
- MO will now register nexus file servers and provides a settings dialog to pick preferred servers. (This preference is not used yet)
- worked around 1-2 bugs in QSortFilterProxy
- handling of nxm links is now done by an external application. This allows the registration of different applications depending on the game
- integrated fomod installer now displays the screenshot in a scalable view
- bugfix: integrated fomod installer didn't name output files correctly if the name differs from the source name
- bugfix: a successful login to nexus was (sometimes?) not correctly detected as a success
- bugfix: top-level entries in QtGroupingProxy were sometimes incorrectly displayed as groups
- bugfix: GetPrivateProfile... optimization could cause null-pointer indirection
- bugfix: GetCurrentWorkingDirectory caused buffer overflow in case of pre-flighting (buffer size 0)
- bugfix: configurator plugin now also uses qt5 (it's currently broken though)

1 files changed, 7 insertions, 3 deletions

diff --git a/src/downloadmanager.cpp b/src/downloadmanager.cpp
index 82a6cb9f..662034c2 100644
--- a/src/downloadmanager.cpp
+++ b/src/downloadmanager.cpp
@@ -21,6 +21,7 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include "report.h"
 #include "nxmurl.h"
 #include <gameinfo.h>
+#include <nxmurl.h>
 #include "utility.h"
 #include "json.h"
 #include "selectiondialog.h"
@@ -673,7 +674,8 @@ void DownloadManager::setState(DownloadManager::DownloadInfo *info, DownloadMana
 
 DownloadManager::DownloadInfo *DownloadManager::findDownload(QObject *reply, int *index) const
 {
-  for (int i = 0; i < m_ActiveDownloads.size(); ++i) {
+  // reverse search as newer, thus more relevant, downloads are at the end
+  for (int i = m_ActiveDownloads.size() - 1; i >= 0; --i) {
     if (m_ActiveDownloads[i]->m_Reply == reply) {
       if (index != NULL) {
         *index = i;
@@ -702,8 +704,11 @@ void DownloadManager::downloadProgress(qint64 bytesReceived, qint64 bytesTotal)
         qDebug("file size %s: %lld", qPrintable(info->m_FileName), bytesTotal);
         info->m_TotalSize = bytesTotal;
       }
+      int oldProgress = info->m_Progress;
       info->m_Progress = ((info->m_ResumePos + bytesReceived) * 100) / (info->m_ResumePos + bytesTotal);
-      emit update(index);
+      if (oldProgress != info->m_Progress) {
+        emit update(index);
+      }
     }
   }
 }
@@ -972,7 +977,6 @@ void DownloadManager::downloadFinished()
   if (info != NULL) {
     QNetworkReply *reply = info->m_Reply;
     QByteArray data = info->m_Reply->readAll();
-    qDebug("finished %s (%d) (%d)", info->m_FileName.toUtf8().constData(), reply->error(), info->m_State);
     info->m_Output.write(data);
     info->m_Output.close();