Merge pull request #362 from Al12rs/dirWatcher

Downloads tab: fix for freezes and greatly improved performance and responsiveness

1 files changed, 17 insertions, 0 deletions

diff --git a/src/downloadmanager.h b/src/downloadmanager.h
index 17ae8a35..aa859b13 100644
--- a/src/downloadmanager.h
+++ b/src/downloadmanager.h
@@ -144,6 +144,17 @@ public:
    **/

   void setOutputDirectory(const QString &outputDirectory);

 

+	/**

+	* @brief disables feedback from the downlods fileSystemWhatcher untill disableDownloadsWatcherEnd() is called

+	* 

+	**/

+	static void startDisableDirWatcher();

+

+	/**

+	* @brief re-enables feedback from the downlods fileSystemWhatcher after disableDownloadsWatcherStart() was called

+	**/

+	static void endDisableDirWatcher();

+

   /**

    * @return current download directory

    **/

@@ -519,6 +530,12 @@ private:
 

   QFileSystemWatcher m_DirWatcher;

 

+	//The dirWatcher is actually triggering off normal Mo operations such as deleting downloads or editing .meta files

+	//so it needs to be disabled during operations that are known to cause the creation or deletion of files in the Downloads folder.

+	//Notably using QSettings to edit a file creates a temporarily .lock file that causes the Watcher to trigger multiple listRefreshes freezing the ui. 

+	static int m_DirWatcherDisabler;

+

+

   std::map<QString, int> m_DownloadFails;

 

   bool m_ShowHidden;