tons of code cleanup and minor fixes to harden the code (mostly suggestions from static code analysis)

1 files changed, 1 insertions, 1 deletions

diff --git a/src/helper.cpp b/src/helper.cpp
index 4c22dbda..1f072bd9 100644
--- a/src/helper.cpp
+++ b/src/helper.cpp
@@ -49,7 +49,7 @@ static bool helperExec(LPCWSTR moDirectory, LPCWSTR commandLine)
 

   ::ShellExecuteExW(&execInfo);

 

-  if (::WaitForSingleObject(execInfo.hProcess, INFINITE) != WAIT_OBJECT_0) {

+  if ((execInfo.hProcess == 0) || (::WaitForSingleObject(execInfo.hProcess, INFINITE) != WAIT_OBJECT_0)) {

     reportError(QObject::tr("helper failed"));

     return false;

   }