bugfix: executables with extensions other than .com, .cmd or .bat were started with cmd.exe (since 1.2.16)

1 files changed, 4 insertions, 3 deletions

diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index 6f6b9a47..fb9fede3 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -4371,6 +4371,7 @@ void MainWindow::installTranslator(const QString &name)
       qWarning("localization file %s not found", qPrintable(fileName));
     } // we don't actually expect localization files for english
   }
+
   qApp->installTranslator(translator);
   m_Translators.push_back(translator);
 }
@@ -4523,9 +4524,9 @@ void MainWindow::writeDataToFile()
 int MainWindow::getBinaryExecuteInfo(const QFileInfo &targetInfo, QFileInfo &binaryInfo, QString &arguments)
 {
   QString extension = targetInfo.completeSuffix();
-  if ((extension.compare("cmd", Qt::CaseInsensitive)) ||
-      (extension.compare("com", Qt::CaseInsensitive)) ||
-      (extension.compare("bat", Qt::CaseInsensitive))) {
+  if ((extension.compare("cmd", Qt::CaseInsensitive) == 0) ||
+      (extension.compare("com", Qt::CaseInsensitive) == 0) ||
+      (extension.compare("bat", Qt::CaseInsensitive) == 0)) {
     binaryInfo = QFileInfo("C:\\Windows\\System32\\cmd.exe");
     arguments = QString("/C \"%1\"").arg(QDir::toNativeSeparators(targetInfo.absoluteFilePath()));
     return 1;