Freeing the credential object when there's no result causes overruns

1 files changed, 1 insertions, 1 deletions

diff --git a/src/settings.cpp b/src/settings.cpp
index 6be5489d..64a39e12 100644
--- a/src/settings.cpp
+++ b/src/settings.cpp
@@ -216,6 +216,7 @@ QString Settings::deObfuscate(const QString key)
   if (CredReadW(keyData, 1, 0, &creds)) {
     wchar_t *charData = (wchar_t *)creds->CredentialBlob;
     result = QString::fromWCharArray(charData, creds->CredentialBlobSize / sizeof(wchar_t));
+    CredFree(creds);
   } else {
     if (GetLastError() != ERROR_NOT_FOUND) {
       wchar_t buffer[256];
@@ -225,7 +226,6 @@ QString Settings::deObfuscate(const QString key)
       qCritical() << "Retrieving encrypted data failed:" << buffer;
     }
   }
-  CredFree(creds);
   delete[] keyData;
   return result;
 }