Merge pull request #252 from LePresidente/new_vfs_library

Update master to latest stable code.

1 files changed, 250 insertions, 128 deletions

diff --git a/src/settings.cpp b/src/settings.cpp
index 03e13826..d1130e05 100644
--- a/src/settings.cpp
+++ b/src/settings.cpp
@@ -24,10 +24,12 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include "settingsdialog.h"
 #include "versioninfo.h"
 #include "appconfig.h"
+#include "organizercore.h"
 #include <utility.h>
 #include <iplugin.h>
 #include <iplugingame.h>
 #include <questionboxmemory.h>
+#include <usvfsparameters.h>
 
 #include <QCheckBox>
 #include <QCoreApplication>
@@ -38,12 +40,16 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include <QDirIterator>
 #include <QFileInfo>
 #include <QLineEdit>
+#include <QSpinBox>
 #include <QListWidgetItem>
 #include <QLocale>
 #include <QMessageBox>
+#include <QApplication>
 #include <QRegExp>
+#include <QDir>
 #include <QStringList>
 #include <QVariantMap>
+#include <QLabel>
 
 #include <Qt> // for Qt::UserRole, etc
 #include <QtDebug> // for qDebug, qWarning
@@ -145,7 +151,7 @@ void Settings::registerPlugin(IPlugin *plugin)
   m_Plugins.push_back(plugin);
   m_PluginSettings.insert(plugin->name(), QMap<QString, QVariant>());
   m_PluginDescriptions.insert(plugin->name(), QMap<QString, QVariant>());
-  foreach (const PluginSetting &setting, plugin->settings()) {
+  for (const PluginSetting &setting : plugin->settings()) {
     QVariant temp = m_Settings.value("Plugins/" + plugin->name() + "/" + setting.key, setting.defaultValue);
     if (!temp.convert(setting.defaultValue.type())) {
       qWarning("failed to interpret \"%s\" as correct type for \"%s\" in plugin \"%s\", using default",
@@ -199,11 +205,16 @@ QString Settings::getSteamAppID() const
   return m_Settings.value("Settings/app_id", m_GamePlugin->steamAPPId()).toString();
 }
 
+bool Settings::usePrereleases() const
+{
+  return m_Settings.value("Settings/use_prereleases", false).toBool();
+}
+
 void Settings::setDownloadSpeed(const QString &serverName, int bytesPerSecond)
 {
   m_Settings.beginGroup("Servers");
 
-  foreach (const QString &serverKey, m_Settings.childKeys()) {
+  for (const QString &serverKey : m_Settings.childKeys()) {
     QVariantMap data = m_Settings.value(serverKey).toMap();
     if (serverKey == serverName) {
       data["downloadCount"] = data["downloadCount"].toInt() + 1;
@@ -221,7 +232,7 @@ std::map<QString, int> Settings::getPreferredServers()
   std::map<QString, int> result;
   m_Settings.beginGroup("Servers");
 
-  foreach (const QString &serverKey, m_Settings.childKeys()) {
+  for (const QString &serverKey : m_Settings.childKeys()) {
     QVariantMap data = m_Settings.value(serverKey).toMap();
     int preference = data["preferred"].toInt();
     if (preference > 0) {
@@ -233,29 +244,54 @@ std::map<QString, int> Settings::getPreferredServers()
   return result;
 }
 
-QString Settings::getConfigurablePath(const QString &key, const QString &def) const
+QString Settings::getConfigurablePath(const QString &key,
+                                      const QString &def,
+                                      bool resolve) const
+{
+  QString result = QDir::fromNativeSeparators(
+      m_Settings.value(QString("settings/") + key, QString("%BASE_DIR%/") + def)
+          .toString());
+  if (resolve) {
+    result.replace("%BASE_DIR%", getBaseDirectory());
+  }
+  return result;
+}
+
+QString Settings::getBaseDirectory() const
 {
-  return QDir::fromNativeSeparators(m_Settings.value(QString("settings/") + key, qApp->property("dataPath").toString() + "/" + def).toString());
+  return QDir::fromNativeSeparators(m_Settings.value(
+      "settings/base_directory", qApp->property("dataPath").toString()).toString());
 }
 
-QString Settings::getDownloadDirectory() const
+QString Settings::getDownloadDirectory(bool resolve) const
 {
-  return getConfigurablePath("download_directory", ToQString(AppConfig::downloadPath()));
+  return getConfigurablePath("download_directory", ToQString(AppConfig::downloadPath()), resolve);
 }
 
-QString Settings::getCacheDirectory() const
+QString Settings::getCacheDirectory(bool resolve) const
 {
-  return getConfigurablePath("cache_directory", ToQString(AppConfig::cachePath()));
+  return getConfigurablePath("cache_directory", ToQString(AppConfig::cachePath()), resolve);
 }
 
-QString Settings::getModDirectory() const
+QString Settings::getModDirectory(bool resolve) const
 {
-  return getConfigurablePath("mod_directory", ToQString(AppConfig::modsPath()));
+  return getConfigurablePath("mod_directory", ToQString(AppConfig::modsPath()), resolve);
+}
+
+QString Settings::getProfileDirectory(bool resolve) const
+{
+  return getConfigurablePath("profiles_directory", ToQString(AppConfig::profilesPath()), resolve);
+}
+
+QString Settings::getOverwriteDirectory(bool resolve) const
+{
+  return getConfigurablePath("overwrite_directory",
+                             ToQString(AppConfig::overwritePath()), resolve);
 }
 
 QString Settings::getNMMVersion() const
 {
-  static const QString MIN_NMM_VERSION = "0.52.3";
+  static const QString MIN_NMM_VERSION = "0.61.13";
   QString result = m_Settings.value("Settings/nmm_version", MIN_NMM_VERSION).toString();
   if (VersionInfo(result) < VersionInfo(MIN_NMM_VERSION)) {
     result = MIN_NMM_VERSION;
@@ -302,9 +338,18 @@ bool Settings::offlineMode() const
 
 int Settings::logLevel() const
 {
-  return m_Settings.value("Settings/log_level", 0).toInt();
+  return m_Settings.value("Settings/log_level", static_cast<int>(LogLevel::Info)).toInt();
 }
 
+int Settings::crashDumpsType() const
+{
+  return m_Settings.value("Settings/crash_dumps_type", static_cast<int>(CrashDumpsType::Mini)).toInt();
+}
+
+int Settings::crashDumpsMax() const
+{
+  return m_Settings.value("Settings/crash_dumps_max", 5).toInt();
+}
 
 void Settings::setNexusLogin(QString username, QString password)
 {
@@ -431,7 +476,7 @@ void Settings::updateServers(const QList<ServerInfo> &servers)
   m_Settings.beginGroup("Servers");
   QStringList oldServerKeys = m_Settings.childKeys();
 
-  foreach (const ServerInfo &server, servers) {
+  for (const ServerInfo &server : servers) {
     if (!oldServerKeys.contains(server.name)) {
       // not yet known server
       QVariantMap newVal;
@@ -453,7 +498,7 @@ void Settings::updateServers(const QList<ServerInfo> &servers)
 
   // clean up unavailable servers
   QDate now = QDate::currentDate();
-  foreach (const QString &key, m_Settings.childKeys()) {
+  for (const QString &key : m_Settings.childKeys()) {
     QVariantMap val = m_Settings.value(key).toMap();
     QDate lastSeen = val["lastSeen"].toDate();
     if (lastSeen.daysTo(now) > 30) {
@@ -477,7 +522,7 @@ void Settings::writePluginBlacklist()
 {
   m_Settings.beginWriteArray("pluginBlacklist");
   int idx = 0;
-  foreach (const QString &plugin, m_PluginBlacklist) {
+  for (const QString &plugin : m_PluginBlacklist) {
     m_Settings.setArrayIndex(idx++);
     m_Settings.setValue("name", plugin);
   }
@@ -523,12 +568,7 @@ void Settings::addLanguages(QComboBox *languageBox)
 void Settings::addStyles(QComboBox *styleBox)
 {
   styleBox->addItem("None", "");
-#if QT_VERSION >= QT_VERSION_CHECK(5,0,0)
   styleBox->addItem("Fusion", "Fusion");
-#else
-  styleBox->addItem("Plastique", "Plastique");
-  styleBox->addItem("Cleanlooks", "Cleanlooks");
-#endif
 
   QDirIterator langIter(QCoreApplication::applicationDirPath() + "/" + ToQString(AppConfig::stylesheetsPath()), QStringList("*.qss"), QDir::Files);
   while (langIter.hasNext()) {
@@ -553,74 +593,95 @@ void Settings::query(QWidget *parent)
   std::vector<std::unique_ptr<SettingsTab>> tabs;
 
   tabs.push_back(std::unique_ptr<SettingsTab>(new GeneralTab(this, dialog)));
+  tabs.push_back(std::unique_ptr<SettingsTab>(new PathsTab(this, dialog)));
+  tabs.push_back(std::unique_ptr<SettingsTab>(new DiagnosticsTab(this, dialog)));
   tabs.push_back(std::unique_ptr<SettingsTab>(new NexusTab(this, dialog)));
   tabs.push_back(std::unique_ptr<SettingsTab>(new SteamTab(this, dialog)));
   tabs.push_back(std::unique_ptr<SettingsTab>(new PluginsTab(this, dialog)));
   tabs.push_back(std::unique_ptr<SettingsTab>(new WorkaroundsTab(this, dialog)));
 
   if (dialog.exec() == QDialog::Accepted) {
+    // remember settings before change
+    QMap<QString, QString> before;
+    m_Settings.beginGroup("Settings");
+    for (auto k : m_Settings.allKeys())
+      before[k] = m_Settings.value(k).toString();
+    m_Settings.endGroup();
+
     // transfer modified settings to configuration file
     for (std::unique_ptr<SettingsTab> const &tab: tabs) {
       tab->update();
     }
+
+    // print "changed" settings
+    m_Settings.beginGroup("Settings");
+    bool first_update = true;
+    for (auto k : m_Settings.allKeys())
+      if (m_Settings.value(k).toString() != before[k] && !k.contains("username") && !k.contains("password"))
+      {
+        if (first_update) {
+          qDebug("Changed settings:");
+          first_update = false;
+        }
+        qDebug("  %s=%s", k.toUtf8().data(), m_Settings.value(k).toString().toUtf8().data());
+      }
+    m_Settings.endGroup();
   }
 }
 
-Settings::SettingsTab::SettingsTab(Settings *m_parent, SettingsDialog &m_dialog) :
-  m_parent(m_parent),
-  m_Settings(m_parent->m_Settings),
-  m_dialog(m_dialog)
-{}
+Settings::SettingsTab::SettingsTab(Settings *m_parent, SettingsDialog &m_dialog)
+  : m_parent(m_parent)
+  , m_Settings(m_parent->m_Settings)
+  , m_dialog(m_dialog)
+{
+}
 
 Settings::SettingsTab::~SettingsTab()
 {}
 
-Settings::GeneralTab::GeneralTab(Settings *m_parent, SettingsDialog &m_dialog) :
-  Settings::SettingsTab(m_parent, m_dialog),
-  m_languageBox(m_dialog.findChild<QComboBox*>("languageBox")),
-  m_styleBox(m_dialog.findChild<QComboBox*>("styleBox")),
-  m_logLevelBox(m_dialog.findChild<QComboBox*>("logLevelBox")),
-  m_downloadDirEdit(m_dialog.findChild<QLineEdit*>("downloadDirEdit")),
-  m_modDirEdit(m_dialog.findChild<QLineEdit*>("modDirEdit")),
-  m_cacheDirEdit(m_dialog.findChild<QLineEdit*>("cacheDirEdit")),
-  m_compactBox(m_dialog.findChild<QCheckBox*>("compactBox")),
-  m_showMetaBox(m_dialog.findChild<QCheckBox*>("showMetaBox"))
+Settings::GeneralTab::GeneralTab(Settings *m_parent, SettingsDialog &m_dialog)
+  : Settings::SettingsTab(m_parent, m_dialog)
+  , m_languageBox(m_dialog.findChild<QComboBox *>("languageBox"))
+  , m_styleBox(m_dialog.findChild<QComboBox *>("styleBox"))
+  , m_compactBox(m_dialog.findChild<QCheckBox *>("compactBox"))
+  , m_showMetaBox(m_dialog.findChild<QCheckBox *>("showMetaBox"))
+  , m_usePrereleaseBox(m_dialog.findChild<QCheckBox *>("usePrereleaseBox"))
+{
+  // FIXME I think 'addLanguages' lives in here not in parent
+  m_parent->addLanguages(m_languageBox);
   {
-    //FIXME I think 'addLanguages' lives in here not in parent
-    m_parent->addLanguages(m_languageBox);
-    {
-      QString languageCode = m_parent->language();
-      int currentID = m_languageBox->findData(languageCode);
-      // I made a mess. :( Most languages are stored with only the iso country code (2 characters like "de") but chinese
-      // with the exact language variant (zh_TW) so I have to search for both variants
-      if (currentID == -1) {
-        currentID = m_languageBox->findData(languageCode.mid(0, 2));
-      }
-      if (currentID != -1) {
-        m_languageBox->setCurrentIndex(currentID);
-      }
+    QString languageCode = m_parent->language();
+    int currentID        = m_languageBox->findData(languageCode);
+    // I made a mess. :( Most languages are stored with only the iso country
+    // code (2 characters like "de") but chinese
+    // with the exact language variant (zh_TW) so I have to search for both
+    // variants
+    if (currentID == -1) {
+      currentID = m_languageBox->findData(languageCode.mid(0, 2));
     }
+    if (currentID != -1) {
+      m_languageBox->setCurrentIndex(currentID);
+    }
+  }
 
-    //FIXME I think addStyles lives in here not in parent
-    m_parent->addStyles(m_styleBox);
-    {
-      int currentID = m_styleBox->findData(m_Settings.value("Settings/style", "").toString());
-      if (currentID != -1) {
-        m_styleBox->setCurrentIndex(currentID);
-      }
+  // FIXME I think addStyles lives in here not in parent
+  m_parent->addStyles(m_styleBox);
+  {
+    int currentID = m_styleBox->findData(
+        m_Settings.value("Settings/style", "").toString());
+    if (currentID != -1) {
+      m_styleBox->setCurrentIndex(currentID);
     }
+  }
 
-    m_logLevelBox->setCurrentIndex(m_parent->logLevel());
-    m_downloadDirEdit->setText(m_parent->getDownloadDirectory());
-    m_modDirEdit->setText(m_parent->getModDirectory());
-    m_cacheDirEdit->setText(m_parent->getCacheDirectory());
-    m_compactBox->setChecked(m_parent->compactDownloads());
-    m_showMetaBox->setChecked(m_parent->metaDownloads());
+  m_compactBox->setChecked(m_parent->compactDownloads());
+  m_showMetaBox->setChecked(m_parent->metaDownloads());
+  m_usePrereleaseBox->setChecked(m_parent->usePrereleases());
 }
 
 void Settings::GeneralTab::update()
 {
-  QString oldLanguage = m_Settings.value("Settings/language", "en_US").toString();
+  QString oldLanguage = m_parent->language();
   QString newLanguage = m_languageBox->itemData(m_languageBox->currentIndex()).toString();
   if (newLanguage != oldLanguage) {
     m_Settings.setValue("Settings/language", newLanguage);
@@ -634,70 +695,131 @@ void Settings::GeneralTab::update()
     emit m_parent->styleChanged(newStyle);
   }
 
-  m_Settings.setValue("Settings/log_level", m_logLevelBox->currentIndex());
+  m_Settings.setValue("Settings/compact_downloads", m_compactBox->isChecked());
+  m_Settings.setValue("Settings/meta_downloads", m_showMetaBox->isChecked());
+  m_Settings.setValue("Settings/use_prereleases", m_usePrereleaseBox->isChecked());
+}
 
-  { // advanced settings
-    if ((QDir::fromNativeSeparators(m_modDirEdit->text()) != QDir::fromNativeSeparators(m_parent->getModDirectory())) &&
-        (QMessageBox::question(nullptr, tr("Confirm"), tr("Changing the mod directory affects all your profiles! "
-                                                       "Mods not present (or named differently) in the new location will be disabled in all profiles. "
-                                                       "There is no way to undo this unless you backed up your profiles manually. Proceed?"),
-                               QMessageBox::Yes | QMessageBox::No) == QMessageBox::No)) {
-      m_modDirEdit->setText(m_parent->getModDirectory());
-    }
+Settings::PathsTab::PathsTab(Settings *parent, SettingsDialog &dialog)
+  : SettingsTab(parent, dialog)
+  , m_baseDirEdit(m_dialog.findChild<QLineEdit *>("baseDirEdit"))
+  , m_downloadDirEdit(m_dialog.findChild<QLineEdit *>("downloadDirEdit"))
+  , m_modDirEdit(m_dialog.findChild<QLineEdit *>("modDirEdit"))
+  , m_cacheDirEdit(m_dialog.findChild<QLineEdit *>("cacheDirEdit"))
+  , m_profilesDirEdit(m_dialog.findChild<QLineEdit *>("profilesDirEdit"))
+  , m_overwriteDirEdit(m_dialog.findChild<QLineEdit *>("overwriteDirEdit"))
+{
+  m_baseDirEdit->setText(m_parent->getBaseDirectory());
 
-    if (!QDir(m_downloadDirEdit->text()).exists()) {
-      QDir().mkpath(m_downloadDirEdit->text());
-    }
-    if (QFileInfo(m_downloadDirEdit->text()) !=
-        QFileInfo(qApp->property("dataPath").toString() + "/" + QString::fromStdWString(AppConfig::downloadPath()))) {
-      m_Settings.setValue("Settings/download_directory", QDir::toNativeSeparators(m_downloadDirEdit->text()));
-    } else {
-      m_Settings.remove("Settings/download_directory");
-    }
+  QString basePath = parent->getBaseDirectory();
+  QDir baseDir(basePath);
+  for (const auto &dir : {
+       std::make_pair(m_downloadDirEdit, m_parent->getDownloadDirectory(false)),
+       std::make_pair(m_modDirEdit, m_parent->getModDirectory(false)),
+       std::make_pair(m_cacheDirEdit, m_parent->getCacheDirectory(false)),
+       std::make_pair(m_profilesDirEdit, m_parent->getProfileDirectory(false)),
+       std::make_pair(m_overwriteDirEdit, m_parent->getOverwriteDirectory(false))
+      }) {
+    QString storePath = baseDir.relativeFilePath(dir.second);
+    storePath = dir.second;
+    dir.first->setText(storePath);
+  }
+}
 
-    if (!QDir(m_modDirEdit->text()).exists()) {
-      QDir().mkpath(m_modDirEdit->text());
-    }
-    if (QFileInfo(m_modDirEdit->text()) !=
-        QFileInfo(qApp->property("dataPath").toString() + "/" + QString::fromStdWString(AppConfig::modsPath()))) {
-      m_Settings.setValue("Settings/mod_directory", QDir::toNativeSeparators(m_modDirEdit->text()));
-    } else {
-      m_Settings.remove("Settings/mod_directory");
-    }
+void Settings::PathsTab::update()
+{
+  typedef std::tuple<QString, QString, std::wstring> Directory;
+
+  QString basePath = m_parent->getBaseDirectory();
 
-    if (!QDir(m_cacheDirEdit->text()).exists()) {
-      QDir().mkpath(m_cacheDirEdit->text());
+  for (const Directory &dir :{
+       Directory{m_downloadDirEdit->text(), "download_directory", AppConfig::downloadPath()},
+       Directory{m_cacheDirEdit->text(), "cache_directory", AppConfig::cachePath()},
+       Directory{m_modDirEdit->text(), "mod_directory", AppConfig::modsPath()},
+       Directory{m_overwriteDirEdit->text(), "overwrite_directory", AppConfig::overwritePath()},
+       Directory{m_profilesDirEdit->text(), "profiles_directory", AppConfig::profilesPath()}
+      }) {
+    QString path, settingsKey;
+    std::wstring defaultName;
+    std::tie(path, settingsKey, defaultName) = dir;
+
+    settingsKey = QString("Settings/%1").arg(settingsKey);
+
+    QString realPath = path;
+    realPath.replace("%BASE_DIR%", m_baseDirEdit->text());
+
+    if (!QDir(realPath).exists()) {
+      if (!QDir().mkpath(realPath)) {
+        QMessageBox::warning(qApp->activeWindow(), tr("Error"),
+                             tr("Failed to create \"%1\", you may not have the "
+                                "necessary permission. path remains unchanged.")
+                                 .arg(realPath));
+      }
     }
-    if (QFileInfo(m_cacheDirEdit->text()) !=
-        QFileInfo(qApp->property("dataPath").toString() + "/" + QString::fromStdWString(AppConfig::cachePath()))) {
-      m_Settings.setValue("Settings/cache_directory", QDir::toNativeSeparators(m_cacheDirEdit->text()));
+
+    if (QFileInfo(realPath)
+        != QFileInfo(basePath + "/" + QString::fromStdWString(defaultName))) {
+      m_Settings.setValue(settingsKey, path);
     } else {
-      m_Settings.remove("Settings/cache_directory");
+      m_Settings.remove(settingsKey);
     }
   }
 
-  m_Settings.setValue("Settings/compact_downloads", m_compactBox->isChecked());
-  m_Settings.setValue("Settings/meta_downloads", m_showMetaBox->isChecked());
+  if (QFileInfo(m_baseDirEdit->text()) !=
+      QFileInfo(qApp->property("dataPath").toString())) {
+    m_Settings.setValue("Settings/base_directory", m_baseDirEdit->text());
+  } else {
+    m_Settings.remove("Settings/base_directory");
+  }
 }
 
-Settings::NexusTab::NexusTab(Settings *m_parent, SettingsDialog &m_dialog) :
-  Settings::SettingsTab(m_parent, m_dialog),
-  m_loginCheckBox(m_dialog.findChild<QCheckBox*>("loginCheckBox")),
-  m_usernameEdit(m_dialog.findChild<QLineEdit*>("usernameEdit")),
-  m_passwordEdit(m_dialog.findChild<QLineEdit*>("passwordEdit")),
-  m_offlineBox(m_dialog.findChild<QCheckBox*>("offlineBox")),
-  m_proxyBox(m_dialog.findChild<QCheckBox*>("proxyBox")),
-  m_knownServersList(m_dialog.findChild<QListWidget*>("knownServersList")),
-  m_preferredServersList(m_dialog.findChild<QListWidget*>("preferredServersList"))
+Settings::DiagnosticsTab::DiagnosticsTab(Settings *m_parent, SettingsDialog &m_dialog)
+  : Settings::SettingsTab(m_parent, m_dialog)
+  , m_logLevelBox(m_dialog.findChild<QComboBox *>("logLevelBox"))
+  , m_dumpsTypeBox(m_dialog.findChild<QComboBox *>("dumpsTypeBox"))
+  , m_dumpsMaxEdit(m_dialog.findChild<QSpinBox *>("dumpsMaxEdit"))
+  , m_diagnosticsExplainedLabel(m_dialog.findChild<QLabel *>("diagnosticsExplainedLabel"))
 {
-  if (m_parent->automaticLoginEnabled()) {
+  m_logLevelBox->setCurrentIndex(m_parent->logLevel());
+  m_dumpsTypeBox->setCurrentIndex(m_parent->crashDumpsType());
+  m_dumpsMaxEdit->setValue(m_parent->crashDumpsMax());
+  QString logsPath = qApp->property("dataPath").toString()
+    + "/" + QString::fromStdWString(AppConfig::logPath());
+  m_diagnosticsExplainedLabel->setText(
+    m_diagnosticsExplainedLabel->text()
+    .replace("LOGS_FULL_PATH", logsPath)
+    .replace("LOGS_DIR", QString::fromStdWString(AppConfig::logPath()))
+    .replace("DUMPS_FULL_PATH", QString::fromStdWString(OrganizerCore::crashDumpsPath()))
+    .replace("DUMPS_DIR", QString::fromStdWString(AppConfig::dumpsDir()))
+  );
+}
+
+void Settings::DiagnosticsTab::update()
+{
+  m_Settings.setValue("Settings/log_level", m_logLevelBox->currentIndex());
+  m_Settings.setValue("Settings/crash_dumps_type", m_dumpsTypeBox->currentIndex());
+  m_Settings.setValue("Settings/crash_dumps_max", m_dumpsMaxEdit->value());
+}
+
+Settings::NexusTab::NexusTab(Settings *parent, SettingsDialog &dialog)
+  : Settings::SettingsTab(parent, dialog)
+  , m_loginCheckBox(dialog.findChild<QCheckBox *>("loginCheckBox"))
+  , m_usernameEdit(dialog.findChild<QLineEdit *>("usernameEdit"))
+  , m_passwordEdit(dialog.findChild<QLineEdit *>("passwordEdit"))
+  , m_offlineBox(dialog.findChild<QCheckBox *>("offlineBox"))
+  , m_proxyBox(dialog.findChild<QCheckBox *>("proxyBox"))
+  , m_knownServersList(dialog.findChild<QListWidget *>("knownServersList"))
+  , m_preferredServersList(
+        dialog.findChild<QListWidget *>("preferredServersList"))
+{
+  if (parent->automaticLoginEnabled()) {
     m_loginCheckBox->setChecked(true);
     m_usernameEdit->setText(m_Settings.value("Settings/nexus_username", "").toString());
     m_passwordEdit->setText(deObfuscate(m_Settings.value("Settings/nexus_password", "").toString()));
   }
 
-  m_offlineBox->setChecked(m_parent->offlineMode());
-  m_proxyBox->setChecked(m_parent->useProxy());
+  m_offlineBox->setChecked(parent->offlineMode());
+  m_proxyBox->setChecked(parent->useProxy());
 
   // display server preferences
   m_Settings.beginGroup("Servers");
@@ -757,11 +879,10 @@ void Settings::NexusTab::update()
   m_Settings.endGroup();
 }
 
-
-Settings::SteamTab::SteamTab(Settings *m_parent, SettingsDialog &m_dialog) :
-  Settings::SettingsTab(m_parent, m_dialog),
-  m_steamUserEdit(m_dialog.findChild<QLineEdit*>("steamUserEdit")),
-  m_steamPassEdit(m_dialog.findChild<QLineEdit*>("steamPassEdit"))
+Settings::SteamTab::SteamTab(Settings *m_parent, SettingsDialog &m_dialog)
+  : Settings::SettingsTab(m_parent, m_dialog)
+  , m_steamUserEdit(m_dialog.findChild<QLineEdit *>("steamUserEdit"))
+  , m_steamPassEdit(m_dialog.findChild<QLineEdit *>("steamPassEdit"))
 {
   if (m_Settings.contains("Settings/steam_username")) {
     m_steamUserEdit->setText(m_Settings.value("Settings/steam_username", "").toString());
@@ -777,10 +898,10 @@ void Settings::SteamTab::update()
   m_parent->setSteamLogin(m_steamUserEdit->text(), m_steamPassEdit->text());
 }
 
-Settings::PluginsTab::PluginsTab(Settings *m_parent, SettingsDialog &m_dialog) :
-  Settings::SettingsTab(m_parent, m_dialog),
-  m_pluginsList(m_dialog.findChild<QListWidget*>("pluginsList")),
-  m_pluginBlacklistList(m_dialog.findChild<QListWidget*>("pluginBlacklist"))
+Settings::PluginsTab::PluginsTab(Settings *m_parent, SettingsDialog &m_dialog)
+  : Settings::SettingsTab(m_parent, m_dialog)
+  , m_pluginsList(m_dialog.findChild<QListWidget *>("pluginsList"))
+  , m_pluginBlacklistList(m_dialog.findChild<QListWidget *>("pluginBlacklist"))
 {
   // display plugin settings
   for (IPlugin *plugin : m_parent->m_Plugins) {
@@ -813,20 +934,21 @@ void Settings::PluginsTab::update()
 
   // store plugin blacklist
   m_parent->m_PluginBlacklist.clear();
-  foreach (QListWidgetItem *item, m_pluginBlacklistList->findItems("*", Qt::MatchWildcard)) {
+  for (QListWidgetItem *item : m_pluginBlacklistList->findItems("*", Qt::MatchWildcard)) {
     m_parent->m_PluginBlacklist.insert(item->text());
   }
   m_parent->writePluginBlacklist();
 }
 
-Settings::WorkaroundsTab::WorkaroundsTab(Settings *m_parent, SettingsDialog &m_dialog) :
-  Settings::SettingsTab(m_parent, m_dialog),
-  m_appIDEdit(m_dialog.findChild<QLineEdit*>("appIDEdit")),
-  m_mechanismBox(m_dialog.findChild<QComboBox*>("mechanismBox")),
-  m_nmmVersionEdit(m_dialog.findChild<QLineEdit*>("nmmVersionEdit")),
-  m_hideUncheckedBox(m_dialog.findChild<QCheckBox*>("hideUncheckedBox")),
-  m_forceEnableBox(m_dialog.findChild<QCheckBox*>("forceEnableBox")),
-  m_displayForeignBox(m_dialog.findChild<QCheckBox*>("displayForeignBox"))
+Settings::WorkaroundsTab::WorkaroundsTab(Settings *m_parent,
+                                         SettingsDialog &m_dialog)
+  : Settings::SettingsTab(m_parent, m_dialog)
+  , m_appIDEdit(m_dialog.findChild<QLineEdit *>("appIDEdit"))
+  , m_mechanismBox(m_dialog.findChild<QComboBox *>("mechanismBox"))
+  , m_nmmVersionEdit(m_dialog.findChild<QLineEdit *>("nmmVersionEdit"))
+  , m_hideUncheckedBox(m_dialog.findChild<QCheckBox *>("hideUncheckedBox"))
+  , m_forceEnableBox(m_dialog.findChild<QCheckBox *>("forceEnableBox"))
+  , m_displayForeignBox(m_dialog.findChild<QCheckBox *>("displayForeignBox"))
 {
   m_appIDEdit->setText(m_parent->getSteamAppID());