- some fixes for qt5 compatibility

- hook.dll no longer creates a dump and uninstalls it if an exception is reported that doesn't originate from it
- NCC used read-only transactions again because otherwise solid archives become unusably slow.
- removed the integrated nexus browser
- the mod description and motd are now rendered in QTextBrowser. This (and the above) eliminates the dependency on qtwebkit
- removed the direct file download for mod files
- reduced CPU usage during downloads by invalidating only one column of the download list. This widget still needs to be replaced
- added the complete filename as an option for the modname
- applications that require elevation can now be started by invoking an elevated secondary ModOrganizer instance
- MO will now register nexus file servers and provides a settings dialog to pick preferred servers. (This preference is not used yet)
- worked around 1-2 bugs in QSortFilterProxy
- handling of nxm links is now done by an external application. This allows the registration of different applications depending on the game
- integrated fomod installer now displays the screenshot in a scalable view
- bugfix: integrated fomod installer didn't name output files correctly if the name differs from the source name
- bugfix: a successful login to nexus was (sometimes?) not correctly detected as a success
- bugfix: top-level entries in QtGroupingProxy were sometimes incorrectly displayed as groups
- bugfix: GetPrivateProfile... optimization could cause null-pointer indirection
- bugfix: GetCurrentWorkingDirectory caused buffer overflow in case of pre-flighting (buffer size 0)
- bugfix: configurator plugin now also uses qt5 (it's currently broken though)

1 files changed, 39 insertions, 2 deletions

diff --git a/src/spawn.cpp b/src/spawn.cpp
index e83c8e21..ab43b687 100644
--- a/src/spawn.cpp
+++ b/src/spawn.cpp
@@ -23,9 +23,11 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include <boost/scoped_array.hpp>
 #include <gameinfo.h>
 #include <inject.h>
+#include <Shellapi.h>
 #include <appconfig.h>
 #include <windows_error.h>
 #include <QApplication>
+#include <QMessageBox>
 
 
 using namespace MOBase;
@@ -105,8 +107,27 @@ HANDLE startBinary(const QFileInfo &binary, const QString &arguments, const QStr
       return INVALID_HANDLE_VALUE;
     }
   } catch (const windows_error &e) {
-    reportError(QObject::tr("failed to spawn \"%1\": %2").arg(binary.fileName()).arg(e.what()));
-    return INVALID_HANDLE_VALUE;
+    if (e.getErrorCode() == ERROR_ELEVATION_REQUIRED) {
+      // TODO: check if this is really correct. Are all settings updated that the secondary instance may use?
+
+      if (QMessageBox::question(NULL, QObject::tr("Elevation required"),
+                                QObject::tr("This process requires elevation to run.\n"
+                                    "This is a potential security risk so I highly advice you to investigate if\n"
+                                    "\"%1\"\n"
+                                    "can be installed to work without elevation.\n\n"
+                                    "Start elevated anyway? "
+                                    "(you will be asked if you want to allow ModOrganizer.exe to make changes to the system)").arg(
+                                        QDir::toNativeSeparators(binary.absoluteFilePath()))) == QMessageBox::Yes) {
+        ::ShellExecuteW(NULL, L"runas", ToWString(QCoreApplication::applicationFilePath()).c_str(),
+                        (binaryName + L" " + ToWString(arguments)).c_str(), currentDirectoryName.c_str(), SW_SHOWNORMAL);
+        return INVALID_HANDLE_VALUE;
+      } else {
+        return INVALID_HANDLE_VALUE;
+      }
+    } else {
+      reportError(QObject::tr("failed to spawn \"%1\": %2").arg(binary.fileName()).arg(e.what()));
+      return INVALID_HANDLE_VALUE;
+    }
   }
 
   if (hooked) {
@@ -134,3 +155,19 @@ HANDLE startBinary(const QFileInfo &binary, const QString &arguments, const QStr
   }
   return processHandle;
 }
+
+
+ExitProxy *ExitProxy::s_Instance = NULL;
+
+ExitProxy *ExitProxy::instance()
+{
+  if (s_Instance == NULL) {
+    s_Instance = new ExitProxy();
+  }
+  return s_Instance;
+}
+
+void ExitProxy::emitExit()
+{
+  emit exit();
+}