Use proper naming convention for constants.

6 files changed, 26 insertions, 24 deletions

diff --git a/src/downloadlist.cpp b/src/downloadlist.cpp
index 93f8538c..9f29f475 100644
--- a/src/downloadlist.cpp
+++ b/src/downloadlist.cpp
@@ -99,7 +99,7 @@ Qt::ItemFlags DownloadList::flags(const QModelIndex& idx) const
 QMimeData* DownloadList::mimeData(const QModelIndexList& indexes) const

 {

   QMimeData* result = QAbstractItemModel::mimeData(indexes);

-  result->setData("text/plain", ModListDropInfo::DOWNLOAD_TEXT);

+  result->setData("text/plain", ModListDropInfo::DownloadText);

   return result;

 }

 

diff --git a/src/modlist.cpp b/src/modlist.cpp
index 81dc91bf..de24fbbd 100644
--- a/src/modlist.cpp
+++ b/src/modlist.cpp
@@ -677,7 +677,7 @@ QStringList ModList::mimeTypes() const
 QMimeData *ModList::mimeData(const QModelIndexList &indexes) const
 {
   QMimeData *result = QAbstractItemModel::mimeData(indexes);
-  result->setData("text/plain", ModListDropInfo::MOD_TEXT);
+  result->setData("text/plain", ModListDropInfo::ModText);
   return result;
 }
 
diff --git a/src/modlistdropinfo.cpp b/src/modlistdropinfo.cpp
index 62a103a4..a247194f 100644
--- a/src/modlistdropinfo.cpp
+++ b/src/modlistdropinfo.cpp
@@ -48,8 +48,8 @@ ModListDropInfo::ModListDropInfo(const QMimeData* mimeData, OrganizerCore& core)
         }
       }
 
-      if (mimeData->text() != ModListDropInfo::MOD_TEXT) {
-        if (mimeData->text() == ModListDropInfo::DOWNLOAD_TEXT && m_rows.size() == 1) {
+      if (mimeData->text() != ModListDropInfo::ModText) {
+        if (mimeData->text() == ModListDropInfo::DownloadText && m_rows.size() == 1) {
           m_download = m_rows[0];
         }
         m_rows = {};
diff --git a/src/modlistdropinfo.h b/src/modlistdropinfo.h
index 14a21691..5d2af92f 100644
--- a/src/modlistdropinfo.h
+++ b/src/modlistdropinfo.h
@@ -18,8 +18,8 @@ public:
   // text value for the mime-data for the various possible
   // origin (not for external drops)
   //
-  static constexpr const char* MOD_TEXT = "mod";
-  static constexpr const char* DOWNLOAD_TEXT = "download";
+  static constexpr const char* ModText = "mod";
+  static constexpr const char* DownloadText = "download";
 
 public:
 
diff --git a/src/settingsdialogplugins.cpp b/src/settingsdialogplugins.cpp
index 16f6fb0a..2f7f3985 100644
--- a/src/settingsdialogplugins.cpp
+++ b/src/settingsdialogplugins.cpp
@@ -40,18 +40,18 @@ PluginsSettingsTab::PluginsSettingsTab(Settings& s, PluginContainer* pluginConta
     QTreeWidgetItem* listItem = new QTreeWidgetItem(
       topItems.at(m_pluginContainer->topImplementedInterface(plugin)));
     listItem->setData(0, Qt::DisplayRole, plugin->localizedName());
-    listItem->setData(0, ROLE_PLUGIN, QVariant::fromValue((void*)plugin));
-    listItem->setData(0, ROLE_SETTINGS, settings().plugins().settings(plugin->name()));
-    listItem->setData(0, ROLE_DESCRIPTIONS, settings().plugins().descriptions(plugin->name()));
+    listItem->setData(0, PluginRole, QVariant::fromValue((void*)plugin));
+    listItem->setData(0, SettingsRole, settings().plugins().settings(plugin->name()));
+    listItem->setData(0, DescriptionsRole, settings().plugins().descriptions(plugin->name()));
 
     // Handle child item:
     auto children = m_pluginContainer->requirements(plugin).children();
     for (auto* child : children) {
       QTreeWidgetItem* childItem = new QTreeWidgetItem(listItem);
       childItem->setData(0, Qt::DisplayRole, child->localizedName());
-      childItem->setData(0, ROLE_PLUGIN, QVariant::fromValue((void*)child));
-      childItem->setData(0, ROLE_SETTINGS, settings().plugins().settings(child->name()));
-      childItem->setData(0, ROLE_DESCRIPTIONS, settings().plugins().descriptions(child->name()));
+      childItem->setData(0, PluginRole, QVariant::fromValue((void*)child));
+      childItem->setData(0, SettingsRole, settings().plugins().settings(child->name()));
+      childItem->setData(0, DescriptionsRole, settings().plugins().descriptions(child->name()));
 
       handledNames.insert(child->name());
     }
@@ -174,7 +174,7 @@ void PluginsSettingsTab::filterPluginList()
 
 IPlugin* PluginsSettingsTab::plugin(QTreeWidgetItem* pluginItem) const
 {
-  return static_cast<IPlugin*>(qvariant_cast<void*>(pluginItem->data(0, ROLE_PLUGIN)));
+  return static_cast<IPlugin*>(qvariant_cast<void*>(pluginItem->data(0, PluginRole)));
 }
 
 void PluginsSettingsTab::update()
@@ -185,7 +185,7 @@ void PluginsSettingsTab::update()
     for (int j = 0; j < topLevelItem->childCount(); ++j) {
       auto* item = topLevelItem->child(j);
       settings().plugins().setSettings(
-        plugin(item)->name(), item->data(0, ROLE_SETTINGS).toMap());
+        plugin(item)->name(), item->data(0, SettingsRole).toMap());
     }
   }
 
@@ -209,7 +209,7 @@ void PluginsSettingsTab::on_checkboxEnabled_clicked(bool checked)
 {
   // Retrieve the plugin:
   auto *item = ui->pluginsList->currentItem();
-  if (!item || !item->data(0, ROLE_PLUGIN).isValid()) {
+  if (!item || !item->data(0, PluginRole).isValid()) {
     return;
   }
   IPlugin* plugin = this->plugin(item);
@@ -278,7 +278,7 @@ void PluginsSettingsTab::on_pluginsList_currentItemChanged(QTreeWidgetItem *curr
 {
   storeSettings(previous);
 
-  if (!current->data(0, ROLE_PLUGIN).isValid()) {
+  if (!current->data(0, PluginRole).isValid()) {
     return;
   }
 
@@ -325,8 +325,8 @@ void PluginsSettingsTab::on_pluginsList_currentItemChanged(QTreeWidgetItem *curr
     }
   }
 
-  QVariantMap settings = current->data(0, ROLE_SETTINGS).toMap();
-  QVariantMap descriptions = current->data(0, ROLE_DESCRIPTIONS).toMap();
+  QVariantMap settings = current->data(0, SettingsRole).toMap();
+  QVariantMap descriptions = current->data(0, DescriptionsRole).toMap();
   ui->pluginSettingsList->setEnabled(settings.count() != 0);
   for (auto iter = settings.begin(); iter != settings.end(); ++iter) {
     QTreeWidgetItem *newItem = new QTreeWidgetItem(QStringList(iter.key()));
@@ -359,14 +359,14 @@ void PluginsSettingsTab::deleteBlacklistItem()
 
 void PluginsSettingsTab::storeSettings(QTreeWidgetItem *pluginItem)
 {
-  if (pluginItem != nullptr && pluginItem->data(0, ROLE_PLUGIN).isValid()) {
-    QVariantMap settings = pluginItem->data(0, ROLE_SETTINGS).toMap();
+  if (pluginItem != nullptr && pluginItem->data(0, PluginRole).isValid()) {
+    QVariantMap settings = pluginItem->data(0, SettingsRole).toMap();
 
     for (int i = 0; i < ui->pluginSettingsList->topLevelItemCount(); ++i) {
       const QTreeWidgetItem *item = ui->pluginSettingsList->topLevelItem(i);
       settings[item->text(0)] = item->data(1, Qt::DisplayRole);
     }
 
-    pluginItem->setData(0, ROLE_SETTINGS, settings);
+    pluginItem->setData(0, SettingsRole, settings);
   }
 }
diff --git a/src/settingsdialogplugins.h b/src/settingsdialogplugins.h
index 3de0d7dc..c784b83e 100644
--- a/src/settingsdialogplugins.h
+++ b/src/settingsdialogplugins.h
@@ -39,9 +39,11 @@ private slots:
    */
   MOBase::IPlugin* plugin(QTreeWidgetItem *pluginItem) const;
 
-  constexpr static int ROLE_PLUGIN = Qt::UserRole;
-  constexpr static int ROLE_SETTINGS = Qt::UserRole + 1;
-  constexpr static int ROLE_DESCRIPTIONS = Qt::UserRole + 2;
+  enum {
+    PluginRole = Qt::UserRole,
+    SettingsRole = Qt::UserRole + 1,
+    DescriptionsRole = Qt::UserRole + 2
+  };
 
 private: