bugfix: categories that reference each other in a cycle could send MO into an endless loop

1 files changed, 5 insertions, 0 deletions

diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index 422207bb..c726991c 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -2113,9 +2113,14 @@ void MainWindow::refreshFilters()
     ModInfo::Ptr modInfo = ModInfo::getByIndex(modIdx);

     for (int categoryID : modInfo->getCategories()) {

       int currentID = categoryID;

+      std::set<int> cycleTest;

       // also add parents so they show up in the tree

       while (currentID != 0) {

         categoriesUsed.insert(currentID);

+        if (!cycleTest.insert(currentID).second) {

+          qWarning("cycle in categories: %s", qPrintable(SetJoin(cycleTest, ", ")));

+          break;

+        }

         currentID = m_CategoryFactory.getParentID(m_CategoryFactory.getCategoryIndex(currentID));

       }

     }