Improve diagnostics if IWYU is enabled

Few small cleanups from clang

3 files changed, 5 insertions, 5 deletions

diff --git a/src/modinfo.h b/src/modinfo.h
index da97b09b..d9de60e8 100644
--- a/src/modinfo.h
+++ b/src/modinfo.h
@@ -1047,7 +1047,7 @@ public:
   virtual QString notes() const { return ""; }

   virtual QDateTime creationTime() const { return QDateTime(); }

   virtual QString absolutePath() const;

-  virtual MOBase::VersionInfo getNewestVersion() const { return ""; }

+  virtual MOBase::VersionInfo getNewestVersion() const { return QString(); }

   virtual QString getInstallationFile() const { return ""; }

   virtual int getFixedPriority() const { return INT_MAX; }

   virtual int getNexusID() const { return -1; }

@@ -1099,7 +1099,7 @@ public:
   virtual QString notes() const { return ""; }

   virtual QDateTime creationTime() const;

   virtual QString absolutePath() const;

-  virtual MOBase::VersionInfo getNewestVersion() const { return ""; }

+  virtual MOBase::VersionInfo getNewestVersion() const { return QString(); }

   virtual QString getInstallationFile() const { return ""; }

   virtual int getNexusID() const { return -1; }

   virtual std::vector<QString> getIniTweaks() const { return std::vector<QString>(); }

diff --git a/src/nexusinterface.cpp b/src/nexusinterface.cpp
index dc027be4..b4775e2d 100644
--- a/src/nexusinterface.cpp
+++ b/src/nexusinterface.cpp
@@ -217,8 +217,8 @@ void NexusInterface::interpretNexusFileName(const QString &fileName, QString &mo
         QString r3Highlight(fileName);

         r3Highlight.insert(result.position(3) + result.length(3), "* ").insert(result.position(3), " *");

 

-        selection.addChoice(candidate.c_str(), r3Highlight, strtol(candidate.c_str(), nullptr, 10));

-        selection.addChoice(candidate2.c_str() + offset, r2Highlight, abs(strtol(candidate2.c_str() + offset, nullptr, 10)));

+        selection.addChoice(candidate.c_str(), r3Highlight, static_cast<int>(strtol(candidate.c_str(), nullptr, 10)));

+        selection.addChoice(candidate2.c_str() + offset, r2Highlight, static_cast<int>(abs(strtol(candidate2.c_str() + offset, nullptr, 10))));

         if (selection.exec() == QDialog::Accepted) {

           modID = selection.getChoiceData().toInt();

         } else {

diff --git a/src/shared/stackdata.cpp b/src/shared/stackdata.cpp
index 6c5a0968..18daaf7b 100644
--- a/src/shared/stackdata.cpp
+++ b/src/shared/stackdata.cpp
@@ -24,7 +24,7 @@ static void initDbgIfNecess()
       firstCall = false;

     }

     if (!::SymInitialize(process, NULL, TRUE)) {

-      printf("failed to initialize symbols: %d", ::GetLastError());

+      printf("failed to initialize symbols: %lu", ::GetLastError());

     }

     initialized.insert(::GetCurrentProcessId());

   }