show a confirmation before switching instances

2 files changed, 44 insertions, 3 deletions

diff --git a/src/instancemanagerdialog.cpp b/src/instancemanagerdialog.cpp
index d579ea9c..b461d39d 100644
--- a/src/instancemanagerdialog.cpp
+++ b/src/instancemanagerdialog.cpp
@@ -294,10 +294,16 @@ void InstanceManagerDialog::openSelectedInstance()
     return;
   }
 
-  if (m_instances[i]->isPortable()) {
+  const auto& to = *m_instances[i];
+
+  if (!confirmSwitch(to)) {
+    return;
+  }
+
+  if (to.isPortable()) {
     InstanceManager::singleton().setCurrentInstance("");
   } else {
-    InstanceManager::singleton().setCurrentInstance(m_instances[i]->name());
+    InstanceManager::singleton().setCurrentInstance(to.name());
   }
 
   if (m_restartOnSelect) {
@@ -307,6 +313,38 @@ void InstanceManagerDialog::openSelectedInstance()
   accept();
 }
 
+bool InstanceManagerDialog::confirmSwitch(const Instance& to)
+{
+  // there might not be a global Settings object if this is called on startup
+  // when there's no current instance
+  const auto* s = Settings::maybeInstance();
+
+  // if there is are no settings, no instances are loaded and the confirmation
+  // wouldn't make sense
+  if (!s) {
+    return true;
+  }
+
+  if (!s->interface().showChangeGameConfirmation()) {
+    // user disabled confirmation
+    return true;
+  }
+
+  MOBase::TaskDialog dlg(this);
+
+  const auto r = dlg
+    .title(tr("Switching instances"))
+    .main(tr("Mod Organizer must restart to manage the instance '%1'.")
+      .arg(to.name()))
+    .content(tr("This confirmation can be disabled in the settings."))
+    .icon(QMessageBox::Question)
+    .button({tr("Restart Mod Organizer"), QMessageBox::Ok})
+    .button({tr("Cancel"), QMessageBox::Cancel})
+    .exec();
+
+  return (r == QMessageBox::Ok);
+}
+
 void InstanceManagerDialog::rename()
 {
   auto* i = singleSelection();
diff --git a/src/instancemanagerdialog.h b/src/instancemanagerdialog.h
index 2641f716..86fe0dac 100644
--- a/src/instancemanagerdialog.h
+++ b/src/instancemanagerdialog.h
@@ -38,7 +38,6 @@ public:
   //
   void openSelectedInstance();
 
-
   // renames the currently selected instance
   //
   void rename();
@@ -110,6 +109,10 @@ private:
   //
   void createNew();
 
+  // shows a confirmation to the user before switching
+  //
+  bool confirmSwitch(const Instance& to);
+
 
   // returns the index of selected instance, NoSelection if none
   //