- renamed instance::name() to displayName() to reduce confusion with portable instances

- better errors when running incorrect shortcuts
- fixed shortcuts being created with moshortcut://Portable:exe instead of an empty instance name for portable instances

1 files changed, 6 insertions, 1 deletions

diff --git a/src/instancemanager.h b/src/instancemanager.h
index 893b88e4..f1781a70 100644
--- a/src/instancemanager.h
+++ b/src/instancemanager.h
@@ -132,9 +132,14 @@ public:
   // returns the instance name; this is the directory name or "Portable" for
   // portable instances
   //
+  // be careful when using this function to check whether two instances are the
+  // same, some parts of MO use an empty string to represent portable instances,
+  // but this function will return "Portable" for them; it's safer to check
+  // for isPortable() first
+  //
   // can be called without setup()
   //
-  QString name() const;
+  QString displayName() const;
 
   // returns either:
   //   1) the game name from the INI, if readFromIni() was called;